feat(ci-visibility): cache Go read requests and add git upload kill switch by tonyredondo · Pull Request #4786 · DataDog/dd-trace-go

tonyredondo · 2026-05-19T16:30:33Z

What does this PR do?

Adds a best-effort, short-lived read cache for Go CI Visibility bootstrap requests.

The cache covers successful decoded responses from:

settings
known tests
skippable tests
test-management tests

The goal is to avoid repeating the same CI Visibility read/bootstrap network requests once per Go package test process in large go test ./... runs. The cache is scoped by repository/test context, endpoint, semantic request body, and either a local parent-process identity or an already-resolved CI identity.

The implementation is fail-open: cache path, filesystem, lock, decode, validation, or staleness problems fall back to the existing live request path. Cache hits preserve decoded feature/test data and content-derived telemetry, while avoiding HTTP request telemetry because no network request happened.

This PR also adds unit coverage for cache keying, TTL selection, storage validation, locking, endpoint behavior, and stale-owner protection. It adds integration coverage for preserving additional-feature initialization across cached reads, plus an E2E-style subprocess test that creates a temporary multi-package Go module and verifies go test ./... across multiple package test processes only hits the mock backend once per cacheable endpoint.

This PR also adds DD_CIVISIBILITY_GIT_UPLOAD_ENABLED as a CI Visibility git upload kill switch. It defaults to true; setting it to false skips repository upload work while keeping CI Visibility enabled. Supported-configuration metadata is updated for this new environment variable. CODEOWNERS, module files, and non-CI Visibility packages are not changed.

Motivation

Large Go repositories can execute many package test binaries during go test ./.... Each package process currently pays the same CI Visibility bootstrap read cost even when the repository, commit, branch, service, environment, test configuration, and CI identity are identical.

This optimization lets package test processes share those read responses for a short TTL through a local file cache, reducing repeated startup network work without changing feature behavior, span behavior, or returned backend data.

Testing

go test ./internal/civisibility/integrations -run TestReadCacheSharesBootstrapAcrossGoTestPackages -count=1 -v
go test ./internal/civisibility/utils/net ./internal/civisibility/integrations
go test -race ./internal/civisibility/utils/net
golangci-lint run ./internal/civisibility/utils/net ./internal/civisibility/integrations
git diff --check
Verified touched files do not add direct os.Getenv / os.LookupEnv usage, raw sync.Mutex / sync.RWMutex usage, or new CI Visibility cache environment variables.

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
There is a benchmark for any new code, or changes to existing code.
If this interacts with the agent in a new way, a system test has been added.
New code is free of linting errors. You can check this by running make lint locally.
New code doesn't break existing tests. You can check this by running make test locally.
Add an appropriate team label so this PR gets put in the right place for the release notes.
All generated files are up to date. You can check this by running make generate locally.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

datadog-datadog-prod-us1 · 2026-05-19T16:35:29Z

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 70.92%
• Overall Coverage: 62.08% (+3.89%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 7147dfc | Docs | Datadog PR Page | Give us feedback!}

codecov · 2026-05-19T16:35:43Z

Codecov Report

❌ Patch coverage is 72.39884% with 191 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.76%. Comparing base (ee0a579) to head (7147dfc).

Files with missing lines	Patch %	Lines
internal/civisibility/utils/net/read_cache.go	68.51%	93 Missing and 49 partials ⚠️
internal/civisibility/utils/net/skippable.go	72.85%	8 Missing and 11 partials ⚠️
...ivisibility/utils/net/test_management_tests_api.go	72.34%	5 Missing and 8 partials ⚠️
internal/civisibility/utils/net/settings_api.go	82.69%	4 Missing and 5 partials ⚠️
internal/civisibility/utils/net/known_tests_api.go	85.71%	3 Missing and 5 partials ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
...civisibility/integrations/civisibility_features.go	`67.98% <100.00%> (ø)`
internal/civisibility/utils/net/client.go	`78.62% <100.00%> (ø)`
internal/civisibility/utils/net/known_tests_api.go	`84.40% <85.71%> (ø)`
internal/civisibility/utils/net/settings_api.go	`85.04% <82.69%> (ø)`
...ivisibility/utils/net/test_management_tests_api.go	`74.52% <72.34%> (ø)`
internal/civisibility/utils/net/skippable.go	`75.28% <72.85%> (ø)`
internal/civisibility/utils/net/read_cache.go	`68.51% <68.51%> (ø)`

... and 447 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2026-05-19T17:12:41Z

Benchmarks

Benchmark execution time: 2026-06-02 16:43:44

Comparing candidate commit 7147dfc in PR branch feat/civisibility-read-cache with baseline commit ee0a579 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 297 metrics, 2 unstable metrics, 1 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

Known flaky benchmarks without significant changes:

scenario:BenchmarkOTLPTraceWriterFlush

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…d-cache # Conflicts: # internal/civisibility/utils/net/known_tests_api.go

tonyredondo · 2026-06-01T15:12:28Z

@codex review

Copilot

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

internal/env/supported_configurations.gen.go: Language not supported

chatgpt-codex-connector · 2026-06-01T15:20:36Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

genesor

LGTM 👍

…witch (#4786) ### What does this PR do? Adds a best-effort, short-lived read cache for Go CI Visibility bootstrap requests. The cache covers successful decoded responses from: - settings - known tests - skippable tests - test-management tests The goal is to avoid repeating the same CI Visibility read/bootstrap network requests once per Go package test process in large `go test ./...` runs. The cache is scoped by repository/test context, endpoint, semantic request body, and either a local parent-process identity or an already-resolved CI identity. The implementation is fail-open: cache path, filesystem, lock, decode, validation, or staleness problems fall back to the existing live request path. Cache hits preserve decoded feature/test data and content-derived telemetry, while avoiding HTTP request telemetry because no network request happened. This PR also adds unit coverage for cache keying, TTL selection, storage validation, locking, endpoint behavior, and stale-owner protection. It adds integration coverage for preserving additional-feature initialization across cached reads, plus an E2E-style subprocess test that creates a temporary multi-package Go module and verifies `go test ./...` across multiple package test processes only hits the mock backend once per cacheable endpoint. This PR also adds `DD_CIVISIBILITY_GIT_UPLOAD_ENABLED` as a CI Visibility git upload kill switch. It defaults to `true`; setting it to `false` skips repository upload work while keeping CI Visibility enabled. Supported-configuration metadata is updated for this new environment variable. `CODEOWNERS`, module files, and non-CI Visibility packages are not changed. ### Motivation Large Go repositories can execute many package test binaries during `go test ./...`. Each package process currently pays the same CI Visibility bootstrap read cost even when the repository, commit, branch, service, environment, test configuration, and CI identity are identical. This optimization lets package test processes share those read responses for a short TTL through a local file cache, reducing repeated startup network work without changing feature behavior, span behavior, or returned backend data. ### Testing - [x] `go test ./internal/civisibility/integrations -run TestReadCacheSharesBootstrapAcrossGoTestPackages -count=1 -v` - [x] `go test ./internal/civisibility/utils/net ./internal/civisibility/integrations` - [x] `go test -race ./internal/civisibility/utils/net` - [x] `golangci-lint run ./internal/civisibility/utils/net ./internal/civisibility/integrations` - [x] `git diff --check` - [x] Verified touched files do not add direct `os.Getenv` / `os.LookupEnv` usage, raw `sync.Mutex` / `sync.RWMutex` usage, or new CI Visibility cache environment variables. ### Reviewer's Checklist  - [ ] Changed code has unit tests for its functionality at or near 100% coverage. - [ ] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag. - [ ] There is a benchmark for any new code, or changes to existing code. - [ ] If this interacts with the agent in a new way, a system test has been added. - [ ] New code is free of linting errors. You can check this by running `make lint` locally. - [ ] New code doesn't break existing tests. You can check this by running `make test` locally. - [ ] Add an appropriate team label so this PR gets put in the right place for the release notes. - [ ] All generated files are up to date. You can check this by running `make generate` locally. - [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally. Co-authored-by: tony.redondo <[email protected]>

feat(ci-visibility): cache Go read bootstrap requests

4c138e0

tonyredondo force-pushed the feat/civisibility-read-cache branch from 5783264 to 4c138e0 Compare May 19, 2026 16:49

tonyredondo added 4 commits May 19, 2026 19:51

test(ci-visibility): cover read cache edge cases

509368e

test(ci-visibility): benchmark read cache paths

ac34a66

Merge branch 'main' into feat/civisibility-read-cache

6ebf71a

feat(ci-visibility): add git upload kill switch

65bc863

tonyredondo changed the title ~~feat(ci-visibility): cache Go read bootstrap requests~~ feat(ci-visibility): cache Go read requests and add git upload kill switch May 22, 2026

tonyredondo marked this pull request as ready for review May 22, 2026 13:17

tonyredondo requested review from a team as code owners May 22, 2026 13:17

tonyredondo requested a review from Copilot May 22, 2026 13:17

Copilot started reviewing on behalf of tonyredondo May 22, 2026 13:17 View session

Copilot AI reviewed May 22, 2026

Merge remote-tracking branch 'origin/main' into feat/civisibility-rea…

a4be24f

…d-cache # Conflicts: # internal/civisibility/utils/net/known_tests_api.go

tonyredondo requested a review from Copilot June 1, 2026 15:09

Copilot started reviewing on behalf of tonyredondo June 1, 2026 15:09 View session

gnufede approved these changes Jun 1, 2026

View reviewed changes

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread internal/civisibility/utils/net/test_management_tests_api.go

fix(ci-visibility): correct test-management error text

eccb92b

genesor approved these changes Jun 2, 2026

View reviewed changes

tonyredondo added 2 commits June 2, 2026 14:13

Merge branch 'main' into feat/civisibility-read-cache

887f4a4

Merge branch 'main' into feat/civisibility-read-cache

3e19d5d

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Jun 2, 2026

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: rejected and removed mergequeue-status: in_progress labels Jun 2, 2026

Merge branch 'main' into feat/civisibility-read-cache

7147dfc

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: rejected mergequeue-status: waiting mergequeue-status: queued labels Jun 2, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 00e3ff8 into main Jun 2, 2026
164 checks passed

gh-worker-dd-devflow-36fce6 Bot removed the mergequeue-status: in_progress label Jun 2, 2026

gh-worker-dd-mergequeue-cf854d Bot deleted the feat/civisibility-read-cache branch June 2, 2026 17:00

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: done label Jun 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ci-visibility): cache Go read requests and add git upload kill switch#4786

feat(ci-visibility): cache Go read requests and add git upload kill switch#4786
gh-worker-dd-mergequeue-cf854d[bot] merged 10 commits into
mainfrom
feat/civisibility-read-cache

tonyredondo commented May 19, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 Bot commented May 19, 2026 •

edited by datadog-prod-us1-6 Bot

Loading

Uh oh!

codecov Bot commented May 19, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented May 19, 2026 •

edited

Loading

Explanation

More details about the CI and significant changes

Known flaky benchmarks

Uh oh!

Copilot AI left a comment

Uh oh!

tonyredondo commented Jun 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Jun 1, 2026

Uh oh!

genesor left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tonyredondo commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Testing

Reviewer's Checklist

Uh oh!

datadog-datadog-prod-us1 Bot commented May 19, 2026 • edited by datadog-prod-us1-6 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Explanation

More details about the CI and significant changes

Known flaky benchmarks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

tonyredondo commented Jun 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Jun 1, 2026

Uh oh!

genesor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tonyredondo commented May 19, 2026 •

edited

Loading

datadog-datadog-prod-us1 Bot commented May 19, 2026 •

edited by datadog-prod-us1-6 Bot

Loading

codecov Bot commented May 19, 2026 •

edited

Loading

pr-commenter Bot commented May 19, 2026 •

edited

Loading