Skip to content

fix(deps): bump klauspost/compress to v1.18.6#4732

Closed
laststem wants to merge 1 commit into
DataDog:mainfrom
laststem:compress-version-up
Closed

fix(deps): bump klauspost/compress to v1.18.6#4732
laststem wants to merge 1 commit into
DataDog:mainfrom
laststem:compress-version-up

Conversation

@laststem

@laststem laststem commented May 6, 2026

Copy link
Copy Markdown

What does this PR do?

Bumps github.com/klauspost/compress from v1.18.4/v1.18.5 to v1.18.6 across all modules in the repo (root + contribs + tools + workflows).

Motivation

Upstream v1.18.6 ships the fix for klauspost/compress#1097 — "s2: Fix amd64 stack frame corruption" — which was causing SIGSEGV crashes inside s2.Decode (observed in franz-go based Kafka consumers). Since our contrib/twmb/franz-go integration sits on the same decode path, we want the fix picked up across the workspace.

No API changes; this is a patch release.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • [] New code is free of linting errors. You can check this by running make lint locally.
  • [] New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • [] All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

@darccio

darccio commented May 12, 2026

Copy link
Copy Markdown
Member

@DataDog/profiling-go Are we good to bump klauspost/compress? I know there have been a recent issue with this library.

@nsrip-dd

Copy link
Copy Markdown
Contributor

@DataDog/profiling-go Are we good to bump klauspost/compress? I know there have been a recent issue with this library.

Yes! I tracked down the bug which this minor version fixes :) Let's bump the dependency. Users are free to upgrade themselves as always, but I think this should be a safe one to bump on our end.

@darccio

darccio commented May 12, 2026

Copy link
Copy Markdown
Member

@laststem Due to recent security policies, I'm going to clone your PR and close it after reviewing it

@datadog-official

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 57.24% (-4.14%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fcec9df | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants