fix(deps): bump klauspost/compress to v1.18.6#4732
Closed
laststem wants to merge 1 commit into
Closed
Conversation
Member
|
@DataDog/profiling-go Are we good to bump |
Contributor
Yes! I tracked down the bug which this minor version fixes :) Let's bump the dependency. Users are free to upgrade themselves as always, but I think this should be a safe one to bump on our end. |
Member
|
@laststem Due to recent security policies, I'm going to clone your PR and close it after reviewing it |
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: fcec9df | Docs | Datadog PR Page | Give us feedback! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps
github.com/klauspost/compressfrom v1.18.4/v1.18.5 to v1.18.6 across all modules in the repo (root + contribs + tools + workflows).Motivation
Upstream v1.18.6 ships the fix for klauspost/compress#1097 — "s2: Fix amd64 stack frame corruption" — which was causing
SIGSEGVcrashes insides2.Decode(observed in franz-go based Kafka consumers). Since ourcontrib/twmb/franz-gointegration sits on the same decode path, we want the fix picked up across the workspace.No API changes; this is a patch release.
Reviewer's Checklist
make lintlocally.make testlocally.make generatelocally.make fix-moduleslocally.