Skip to content

fix(internal/civisibility): resolve trimpath source files#4706

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
feat/civisibility-trimpath-source-paths
Apr 29, 2026
Merged

fix(internal/civisibility): resolve trimpath source files#4706
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
feat/civisibility-trimpath-source-paths

Conversation

@tonyredondo

@tonyredondo tonyredondo commented Apr 29, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Fixes CI Visibility test source resolution when Go test binaries are built with -trimpath.

runtime.Func.FileLine can return a logical module path such as github.com/DataDog/dd-trace-go/v2/internal/... instead of a local filesystem path. SetTestFunc previously used that single value for both source tags and source parsing, which could leave test.source.file with the module prefix and prevent AST parsing from finding source ranges.

This PR adds a source-path resolver that keeps those concerns separate:

  • repository-relative paths for test.source.file, CODEOWNERS, and impacted-tests inputs
  • best-effort filesystem paths for source parsing

The resolver preserves the existing legacy helper behavior for other callers, handles repository URL normalization, supports semantic import suffixes like /v2, preserves monorepo module subdirectories, and includes Windows-specific path coverage.

Motivation

Fix CI Visibility source metadata for -trimpath test binaries, including the bug reported in DataDog/orchestrion#826, without changing unrelated path handling for existing CI Visibility callers.

Testing

  • go test ./internal/civisibility/utils -count=1
  • go test ./internal/civisibility/integrations -count=1
  • go test ./internal/civisibility/integrations/gotesting -count=1
  • go test ./internal/civisibility/... -count=1
  • go test -trimpath ./internal/civisibility/... -count=1
  • go test -race ./internal/civisibility/... -count=1
  • go test -race -trimpath ./internal/civisibility/... -count=1
  • git diff --check

@tonyredondo
tonyredondo requested a review from a team as a code owner April 29, 2026 16:44
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Apr 29, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 80.69%
• Overall Coverage: 61.44% (+3.99%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f0078b3 | Docs | Datadog PR Page | Give us feedback!

@tonyredondo tonyredondo mentioned this pull request Apr 29, 2026
Open
@pr-commenter

pr-commenter Bot commented Apr 29, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-29 17:27:56

Comparing candidate commit f0078b3 in PR branch feat/civisibility-trimpath-source-paths with baseline commit 2743f8e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 207 metrics, 9 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 7e5ced7 into main Apr 29, 2026
193 of 194 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the feat/civisibility-trimpath-source-paths branch April 29, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufede gnufede gnufede approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonyredondo @gnufede