Skip to content

perf(internal/civisibility): reuse missing commit list#4703

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
feat/civisibility-reuse-missing-commits
Apr 28, 2026
Merged

perf(internal/civisibility): reuse missing commit list#4703
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
feat/civisibility-reuse-missing-commits

Conversation

@tonyredondo

@tonyredondo tonyredondo commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

  • compute the initial missing commit list once during repository change upload
  • reuse the same ordered list when falling back to the initial commit data
  • add tests that lock current missing-commit ordering and duplicate behavior

Testing

  • go test ./internal/civisibility/integrations -count=1
  • go test ./internal/civisibility/integrations/... -count=1
  • go test ./internal/civisibility/... -count=1

@tonyredondo
tonyredondo requested a review from a team as a code owner April 28, 2026 14:19
@codecov

codecov Bot commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.99%. Comparing base (dd18ece) to head (3028ebb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...civisibility/integrations/civisibility_features.go 0.00% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...civisibility/integrations/civisibility_features.go 32.58% <0.00%> (ø)

... and 446 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 71.43%
• Overall Coverage: 61.33% (+4.10%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6b0c0b9 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-28 16:31:11

Comparing candidate commit 6b0c0b9 in PR branch feat/civisibility-reuse-missing-commits with baseline commit 686e98e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 271 metrics, 7 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@tonyredondo

tonyredondo commented Apr 28, 2026

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-04-28 16:53:30 UTC ℹ️ Start processing command /merge

2026-04-28 16:53:35 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 16m (p90).

2026-04-28 17:08:25 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit f8372ae into main Apr 28, 2026
193 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the feat/civisibility-reuse-missing-commits branch April 28, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufede gnufede gnufede approved these changes
@juan-fernandez juan-fernandez juan-fernandez approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tonyredondo @gnufede @juan-fernandez