Skip to content

fix(contrib/99designs/gqlgen): bump to v0.17.90, adjust tests accordingly#4702

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
dario.castane/ktlo/99designs-locations
Apr 28, 2026
Merged

fix(contrib/99designs/gqlgen): bump to v0.17.90, adjust tests accordingly#4702
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
dario.castane/ktlo/99designs-locations

Conversation

@darccio

@darccio darccio commented Apr 28, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Updates 99designs/gqlgen to v0.17.90, which introduces a small behaviour change that causes our tests to fail.

Motivation

Fix smoke tests.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

@darccio
darccio requested review from a team as code owners April 28, 2026 11:58
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Apr 28, 2026
@datadog-official

datadog-official Bot commented Apr 28, 2026 •
edited by datadog-prod-us1-6 Bot
Loading

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: -1.00%
• Overall Coverage: 61.24% (+4.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6912fc0 | Docs | Datadog PR Page | Give us feedback!

rarguelloF
rarguelloF approved these changes Apr 28, 2026
View reviewed changes

@rarguelloF rarguelloF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pr-commenter

pr-commenter Bot commented Apr 28, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-28 12:48:25

Comparing candidate commit 6912fc0 in PR branch dario.castane/ktlo/99designs-locations with baseline commit 749408d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 270 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@darccio

darccio commented Apr 28, 2026

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-04-28 13:36:21 UTC ℹ️ Start processing command /merge

2026-04-28 13:36:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 15m (p90).

2026-04-28 13:52:28 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 8606cca into main Apr 28, 2026
238 of 239 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the dario.castane/ktlo/99designs-locations branch April 28, 2026 13:52
darccio added a commit that referenced this pull request May 4, 2026
@darccio
fix(contrib/99designs/gqlgen): bump to v0.17.90, adjust tests accordi…
0eb8f31 
…ngly (#4702)

Updates `99designs/gqlgen` to `v0.17.90`, which introduces a small behaviour change that causes our tests to fail.

Fix smoke tests.

- [ ] Changed code has unit tests for its functionality at or near 100% coverage.
- [ ] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag.
- [ ] There is a benchmark for any new code, or changes to existing code.
- [ ] If this interacts with the agent in a new way, a system test has been added.
- [ ] New code is free of linting errors. You can check this by running `make lint` locally.
- [ ] New code doesn't break existing tests. You can check this by running `make test` locally.
- [ ] Add an appropriate team label so this PR gets put in the right place for the release notes.
- [ ] All generated files are up to date. You can check this by running `make generate` locally.
- [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally.

Unsure? Have a question? Request a review!

Co-authored-by: dario.castane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rarguelloF rarguelloF rarguelloF approved these changes
@hannahkm hannahkm hannahkm approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darccio @rarguelloF @hannahkm