perf(internal/civisibility): cache SetTestFunc source metadata by tonyredondo · Pull Request #4691 · DataDog/dd-trace-go

tonyredondo · 2026-04-23T15:43:45Z

What does this PR do?

Caches the source metadata used by (*tslvTest).SetTestFunc so each source file is parsed once per process instead of being reparsed on every call.

The change keeps the existing behavior intact while moving the AST work into a per-file cache:

preserves the same source tags, unskippable semantics, impacted-tests inputs, code-owner lookup, and debug log messages
keeps the current declaration-vs-literal matching rules, including the existing literal line-tolerance heuristic
adds regression tests for repeated lookups, repeated log emission, suite-level and declaration-level unskippable, negative parse caching, concurrent cache access, and declarations without bodies
resets the new cache in test helpers so package tests remain isolated

Motivation

Profiling internal/civisibility/integrations/gotesting consistently showed repeated go/parser.ParseFile work inside SetTestFunc as the main internal hotspot. This removes that repeated parsing without changing the observable behavior of the integration.

Validation run for this change:

go test ./internal/civisibility/integrations/...
go test ./internal/civisibility/integrations/gotesting/...
go test ./internal/civisibility/...
repeated local profiling of TestFlakyTestRetries=1 go test -cpuprofile=... -memprofile=... . in internal/civisibility/integrations/gotesting, confirming go/parser.ParseFile drops from a repeated hotspot to one-time metadata loading

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
There is a benchmark for any new code, or changes to existing code.
If this interacts with the agent in a new way, a system test has been added.
New code is free of linting errors. You can check this by running make lint locally.
New code doesn't break existing tests. You can check this by running make test locally.
Add an appropriate team label so this PR gets put in the right place for the release notes.
All generated files are up to date. You can check this by running make generate locally.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

datadog-official · 2026-04-23T15:47:31Z

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 98.51%
• Overall Coverage: 61.12% (+0.09%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 681734c | Docs | Datadog PR Page | Give us feedback!}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01a6fd0071

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codecov · 2026-04-23T16:35:47Z

Codecov Report

❌ Patch coverage is 98.44961% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.81%. Comparing base (4dab362) to head (22fa2c3).

Files with missing lines	Patch %	Lines
...nal/civisibility/integrations/manual_api_ddtest.go	91.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
...ivisibility/integrations/manual_api_sourcecache.go	`100.00% <100.00%> (ø)`
internal/civisibility/utils/git.go	`56.48% <100.00%> (-10.75%)`	⬇️
...nal/civisibility/integrations/manual_api_ddtest.go	`56.15% <91.66%> (-7.97%)`	⬇️

... and 273 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2026-04-23T17:42:03Z

Benchmarks

Benchmark execution time: 2026-04-24 15:51:36

Comparing candidate commit 681734c in PR branch feat/civisibility-settestfunc-source-cache with baseline commit 4dab362 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 271 metrics, 7 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

perf(internal/civisibility): cache SetTestFunc source metadata

01a6fd0

tonyredondo requested a review from a team as a code owner April 23, 2026 15:43

chatgpt-codex-connector Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread internal/civisibility/integrations/manual_api_sourcecache.go Outdated

tonyredondo added 3 commits April 23, 2026 18:02

fix(internal/civisibility): disambiguate same-named test methods

6042401

Merge branch 'main' into feat/civisibility-settestfunc-source-cache

7c001bd

fix(ci): harden detached-head and Windows uploads

974708f

tonyredondo requested a review from a team as a code owner April 23, 2026 16:27

revert: restore dd-ci upload workflow

80aa558

chore: rerun CI

17fef5a

gnufede approved these changes Apr 24, 2026

View reviewed changes

tonyredondo added 2 commits April 24, 2026 15:31

fix(civisibility): resolve generated func source ranges

22fa2c3

fix(civisibility): prefer exact literal source matches

681734c

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Apr 24, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 62de3fa into main Apr 24, 2026
190 of 192 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the feat/civisibility-settestfunc-source-cache branch April 24, 2026 16:09

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Apr 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf(internal/civisibility): cache SetTestFunc source metadata#4691

perf(internal/civisibility): cache SetTestFunc source metadata#4691
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits into
mainfrom
feat/civisibility-settestfunc-source-cache

tonyredondo commented Apr 23, 2026

Uh oh!

datadog-official Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

codecov Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented Apr 23, 2026 •

edited

Loading

Explanation

More details about the CI and significant changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tonyredondo commented Apr 23, 2026

What does this PR do?

Motivation

Reviewer's Checklist

Uh oh!

datadog-official Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Explanation

More details about the CI and significant changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

datadog-official Bot commented Apr 23, 2026 •

edited

Loading

codecov Bot commented Apr 23, 2026 •

edited

Loading

pr-commenter Bot commented Apr 23, 2026 •

edited

Loading