Skip to content

fix(internal/telemetry): don't use default dependency loader in telemetry tests (2)#4676

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
dario.castane/ktlo/gotip-TestMetricsDisabled
Apr 20, 2026
Merged

fix(internal/telemetry): don't use default dependency loader in telemetry tests (2)#4676
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
dario.castane/ktlo/gotip-TestMetricsDisabled

Conversation

@darccio

@darccio darccio commented Apr 18, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Extends #4673 to TestMetricsDisabled.

Motivation

Same gotip fix as in previous PR, but this one went unnoticed accidentally. The whole telemetry suite has been tested under gotip to ensure no more fixes are needed.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

Unsure? Have a question? Request a review!

@darccio
fix(internal/telemetry): don't use default dependency loader in telem…
6570d34 
…etry tests (2)

Root cause: commit a45c8032 in golang/go: "cmd/go: include test deps in buildinfo" (merged ~March 17, 2026, landed in gotip). Fixed golang/go#76926.

Before this, test binary BuildInfo.Deps was empty → dependencies.Payload() returned nil → only Logs in flush → test passed. After: test deps populate Deps → AppDependenciesLoaded joins flush → 2 payloads → MessageBatch → test fails.

Apparently this is flaky but went unnoticed. Looking at historical data, odds to fail since the commit landed on gotip were 1 of every 10-ish.
@codecov

codecov Bot commented Apr 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.53%. Comparing base (9f3aa1f) to head (6570d34).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

see 275 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Apr 18, 2026 •
edited by datadog-prod-us1-3 Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: -1.00%
• Overall Coverage: 60.89% (+4.19%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6570d34 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter

pr-commenter Bot commented Apr 18, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-18 10:05:52

Comparing candidate commit 6570d34 in PR branch dario.castane/ktlo/gotip-TestMetricsDisabled with baseline commit 9f3aa1f in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 268 metrics, 9 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:BenchmarkPartialFlushing/Disabled-25

  • 🟩 avgHeapInUse(Mb) [-4.676MB; -1.602MB] or [-7.883%; -2.700%]

@darccio
darccio marked this pull request as ready for review April 20, 2026 08:11
@darccio
darccio requested a review from a team as a code owner April 20, 2026 08:11
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 6114618 into main Apr 20, 2026
193 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the dario.castane/ktlo/gotip-TestMetricsDisabled branch April 20, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genesor genesor genesor approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done team:apm-go

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darccio @genesor