Skip to content

fix(contrib/aws/aws-sdk-go-v2): skip _datadog attribute if batch size larger than 262144-byte payload limit#4665

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
dario.castane/er/issue-4464
Apr 21, 2026
Merged

fix(contrib/aws/aws-sdk-go-v2): skip _datadog attribute if batch size larger than 262144-byte payload limit#4665
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
dario.castane/er/issue-4464

Conversation

@darccio

@darccio darccio commented Apr 16, 2026

Copy link
Copy Markdown
Member

What does this PR do?

SNS _datadog trace context injection (about 338 bytes) was unconditionally added to every message, pushing payloads over SNS's 262,144-byte limit and causing BatchRequestTooLong errors.

Motivation

Fixes #4664.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

Unsure? Have a question? Request a review!

@darccio darccio added the apm:ecosystem contrib/* related feature requests or bugs label Apr 16, 2026
@darccio
darccio requested review from a team as code owners April 16, 2026 16:03
@codecov

codecov Bot commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.00%. Comparing base (b107050) to head (9e3dd3c).

Additional details and impacted files

see 378 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

datadog-official Bot commented Apr 16, 2026 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 60.90% (+4.18%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9e3dd3c | Docs | Datadog PR Page | Give us feedback!

@darccio

darccio commented Apr 16, 2026

Copy link
Copy Markdown
Member Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Apr 16, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9506d95b00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread contrib/aws/aws-sdk-go-v2/internal/sns/sns.go Outdated
@pr-commenter

pr-commenter Bot commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-21 20:24:54

Comparing candidate commit 9e3dd3c in PR branch dario.castane/er/issue-4464 with baseline commit b107050 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 270 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

rarguelloF
rarguelloF approved these changes Apr 21, 2026
View reviewed changes

@rarguelloF rarguelloF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darccio

darccio commented Apr 21, 2026

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-04-21 14:07:31 UTC ℹ️ Start processing command /merge

2026-04-21 14:07:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 15m (p90).

2026-04-21 15:21:32 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 4bd02bb into main Apr 21, 2026
193 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the dario.castane/er/issue-4464 branch April 21, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@rarguelloF rarguelloF rarguelloF approved these changes
@hannahkm hannahkm hannahkm approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Orchestrion injecting _datadog attribute into SNS message breaks 262144-byte payload limit

3 participants

@darccio @rarguelloF @hannahkm