Skip to content

feat(contrib/redis/rueidis): add SetOnInvalidations to dedicatedClient#4659

Merged
darccio merged 1 commit into
mainfrom
dario.castane/ktlo/redis-implement-setoninvalidations
Apr 14, 2026
Merged

feat(contrib/redis/rueidis): add SetOnInvalidations to dedicatedClient#4659
darccio merged 1 commit into
mainfrom
dario.castane/ktlo/redis-implement-setoninvalidations

Conversation

@darccio

@darccio darccio commented Apr 14, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Mirrors #4657 on contrib/redis/rueidis.

Motivation

Fix smoke-tests.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner April 14, 2026 08:44
@darccio darccio added the apm:ecosystem contrib/* related feature requests or bugs label Apr 14, 2026
@darccio
darccio requested a review from a team as a code owner April 14, 2026 08:44
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Apr 14, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 60.07%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b486651 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.75%. Comparing base (43ac765) to head (b486651).

Additional details and impacted files

see 443 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-17 20:48:57

Comparing candidate commit b486651 in PR branch dario.castane/ktlo/redis-implement-setoninvalidations with baseline commit 43ac765 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 215 metrics, 9 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@darccio
darccio merged commit dd184a0 into main Apr 14, 2026
232 of 233 checks passed
@darccio
darccio deleted the dario.castane/ktlo/redis-implement-setoninvalidations branch April 14, 2026 09:30
darccio added a commit that referenced this pull request Apr 17, 2026
@darccio
feat(contrib/redis/rueidis): add SetOnInvalidations to `dedicatedCl…
a859be1 
…ient` (#4659)

Mirrors #4657 on `contrib/redis/rueidis`.

Fix `smoke-tests`.

- [x] Changed code has unit tests for its functionality at or near 100%
coverage.
- [x] New code is free of linting errors. You can check this by running
`make lint` locally.
- [x] New code doesn't break existing tests. You can check this by
running `make test` locally.
- [x] Add an appropriate team label so this PR gets put in the right
place for the release notes.
- [x] All generated files are up to date. You can check this by running
`make generate` locally.
- [x] Non-trivial go.mod changes, e.g. adding new modules, are reviewed
by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to
date by running `make fix-modules` locally.

Unsure? Have a question? Request a review!
@darccio
darccio restored the dario.castane/ktlo/redis-implement-setoninvalidations branch April 17, 2026 20:20
@darccio
darccio deleted the dario.castane/ktlo/redis-implement-setoninvalidations branch April 17, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rarguelloF rarguelloF rarguelloF approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darccio @rarguelloF