feat(contrib/valkey-io): bump valkey-go and add SetOnInvalidations wrapper#4657
Merged
Conversation
darccio
approved these changes
Apr 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Member
|
Hi @Scorfly, thanks for the PR! Please run |
6 tasks
Upgrade valkey-go to v1.0.74, which extends DedicatedClient with SetOnInvalidations for client-side caching invalidations. Delegate the new hook on the traced dedicated client so the wrapper still implements the upstream interface.
Scorfly
force-pushed
the
bump-valkey-version
branch
from
April 14, 2026 08:55
b0711f3 to
b157a04
Compare
rarguelloF
approved these changes
Apr 14, 2026
darccio
added a commit
that referenced
this pull request
Apr 14, 2026
…ient` (#4659) ### What does this PR do? Mirrors #4657 on `contrib/redis/rueidis`. ### Motivation Fix `smoke-tests`. ### Reviewer's Checklist - [x] Changed code has unit tests for its functionality at or near 100% coverage. - [x] New code is free of linting errors. You can check this by running `make lint` locally. - [x] New code doesn't break existing tests. You can check this by running `make test` locally. - [x] Add an appropriate team label so this PR gets put in the right place for the release notes. - [x] All generated files are up to date. You can check this by running `make generate` locally. - [x] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally. Unsure? Have a question? Request a review!
darccio
added a commit
that referenced
this pull request
Apr 17, 2026
…ient` (#4659) Mirrors #4657 on `contrib/redis/rueidis`. Fix `smoke-tests`. - [x] Changed code has unit tests for its functionality at or near 100% coverage. - [x] New code is free of linting errors. You can check this by running `make lint` locally. - [x] New code doesn't break existing tests. You can check this by running `make test` locally. - [x] Add an appropriate team label so this PR gets put in the right place for the release notes. - [x] All generated files are up to date. You can check this by running `make generate` locally. - [x] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally. Unsure? Have a question? Request a review!
darccio
pushed a commit
that referenced
this pull request
Apr 17, 2026
…apper (#4657) Upgrade valkey-go to v1.0.74, which extends DedicatedClient with SetOnInvalidations for client-side caching invalidations. Delegate the new hook on the traced dedicated client so the wrapper still implements the upstream interface. We cannot bump the valkey lib in our project. They added the `SetOnInvalidations` on the `DedicatedClient` interface - valkey-io/valkey-go@26dc6e8 It create issue on DataDog lib side because it does not match the interface ```console ~/work/DataDog/dd-trace-go/contrib/valkey-io/valkey-go git:(main) ✗ $ go test ./... go: downloading github.com/DataDog/datadog-go v3.2.0+incompatible go: downloading google.golang.org/genproto v0.0.0-20251022142026-3a174f9686a8 ./valkey.go:129:13: cannot use &dedicatedClient{…} (value of type *dedicatedClient) as "github.com/valkey-io/valkey-go".DedicatedClient value in argument to fn: *dedicatedClient does not implement "github.com/valkey-io/valkey-go".DedicatedClient (missing method SetOnInvalidations) ./valkey.go:138:9: cannot use &dedicatedClient{…} (value of type *dedicatedClient) as "github.com/valkey-io/valkey-go".DedicatedClient value in return statement: *dedicatedClient does not implement "github.com/valkey-io/valkey-go".DedicatedClient (missing method SetOnInvalidations) ./valkey.go:165:29: cannot use (*dedicatedClient)(nil) (value of type *dedicatedClient) as "github.com/valkey-io/valkey-go".DedicatedClient value in variable declaration: *dedicatedClient does not implement "github.com/valkey-io/valkey-go".DedicatedClient (missing method SetOnInvalidations) FAIL github.com/DataDog/dd-trace-go/contrib/valkey-io/valkey-go/v2 [build failed] FAIL ``` - [ ] Changed code has unit tests for its functionality at or near 100% coverage. - [ ] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag. - [ ] There is a benchmark for any new code, or changes to existing code. - [x] If this interacts with the agent in a new way, a system test has been added. - [x] New code is free of linting errors. You can check this by running `make lint` locally. - [x] New code doesn't break existing tests. You can check this by running `make test` locally. - [ ] Add an appropriate team label so this PR gets put in the right place for the release notes. - [x] All generated files are up to date. You can check this by running `make generate` locally. - [x] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade valkey-go to v1.0.74, which extends DedicatedClient with SetOnInvalidations for client-side caching invalidations. Delegate the new hook on the traced dedicated client so the wrapper still implements the upstream interface.
Motivation
We cannot bump the valkey lib in our project.
They added the
SetOnInvalidationson theDedicatedClientinterfaceIt create issue on DataDog lib side because it does not match the interface
Reviewer's Checklist
make lintlocally.make testlocally.make generatelocally.make fix-moduleslocally.