Skip to content

feat(profiler): remove the goroutine wait profile type#4589

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
nick.ripley/remove-goroutine-wait-profile
Apr 8, 2026
Merged

feat(profiler): remove the goroutine wait profile type#4589
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
nick.ripley/remove-goroutine-wait-profile

Conversation

@nsrip-dd

@nsrip-dd nsrip-dd commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

This profile type never made it out of alpha. It was only ever visible
in the UI internally and is not frequently used. At this point we have
the thread timeline and now the goroutine leak profile, which are both
well suited for the kinds of problems the goroutine wait profile was
meant to solve.

PROF-14036

@nsrip-dd
nsrip-dd force-pushed the nick.ripley/remove-goroutine-wait-profile branch from c8c60dd to eb54b51 Compare March 30, 2026 14:54
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Mar 30, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.97%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 80a38a1 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@nsrip-dd
nsrip-dd force-pushed the nick.ripley/remove-goroutine-wait-profile branch from eb54b51 to af0c9b6 Compare March 30, 2026 15:15
@codecov

codecov Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.61%. Comparing base (e36675b) to head (80a38a1).

Additional details and impacted files
Files with missing lines Coverage Δ
profiler/compression.go 86.40% <100.00%> (ø)
profiler/options.go 91.62% <ø> (ø)
profiler/profile.go 80.12% <ø> (ø)
profiler/profiler.go 86.36% <ø> (ø)
profiler/telemetry.go 87.80% <ø> (ø)

... and 435 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nsrip-dd
nsrip-dd force-pushed the nick.ripley/remove-goroutine-wait-profile branch from af0c9b6 to 7b90954 Compare March 30, 2026 15:38
nsrip-dd
nsrip-dd commented Mar 30, 2026
View reviewed changes
Comment thread profiler/profile.go
@pr-commenter

pr-commenter Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-08 14:17:12

Comparing candidate commit 80a38a1 in PR branch nick.ripley/remove-goroutine-wait-profile with baseline commit e36675b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 216 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@nsrip-dd
nsrip-dd marked this pull request as ready for review March 30, 2026 15:59
@nsrip-dd
nsrip-dd requested a review from a team as a code owner March 30, 2026 15:59
felixge
felixge approved these changes Apr 7, 2026
View reviewed changes

@felixge felixge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay.

Comment thread profiler/profile.go
@nsrip-dd

nsrip-dd commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-04-07 10:29:53 UTC ℹ️ Start processing command /merge

2026-04-07 10:29:58 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 27m (p90).

2026-04-07 10:39:36 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 08b2d5c:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@nsrip-dd

nsrip-dd commented Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Apr 8, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-04-08 10:35:20 UTC ℹ️ Start processing command /merge

2026-04-08 10:35:26 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-04-08 10:39:46 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@nsrip-dd
feat(profiler): remove the goroutine wait profile type
80a38a1 
This profile type never made it out of alpha. It was only ever visible
in the UI internally and is not frequently used. At this point we have
the thread timeline and now the goroutine leak profile, which are both
well suited for the kinds of problems the goroutine wait profile was
meant to solve.
@nsrip-dd
nsrip-dd force-pushed the nick.ripley/remove-goroutine-wait-profile branch from 0d00fe4 to 80a38a1 Compare April 8, 2026 13:49
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 61221f3 into main Apr 8, 2026
231 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the nick.ripley/remove-goroutine-wait-profile branch April 8, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixge felixge felixge approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nsrip-dd @felixge