Skip to content

fix(internal/telemetry): avoid flakiness on telemetry tests; pin localstack/localstack#4581

Merged
darccio merged 2 commits into
mainfrom
dario.castane/ktlo/incident-51506
Mar 23, 2026
Merged

fix(internal/telemetry): avoid flakiness on telemetry tests; pin localstack/localstack#4581
darccio merged 2 commits into
mainfrom
dario.castane/ktlo/incident-51506

Conversation

@darccio

@darccio darccio commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Avoids flakiness on telemetry tests on gotip by disabling DependencyLoader when running them.

Pins localstack/localstack to latest known version that doesn't require license/auth to stabilize CI while we decide how to use it from now on.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner March 23, 2026 10:11
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Mar 23, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.73% (-0.07%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 59b9265 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov

codecov Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.53%. Comparing base (f3970b8) to head (59b9265).

Additional details and impacted files

see 257 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-23 12:05:57

Comparing candidate commit 59b9265 in PR branch dario.castane/ktlo/incident-51506 with baseline commit f3970b8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 216 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@darccio
darccio requested a review from a team as a code owner March 23, 2026 11:37
@darccio darccio changed the title fix(internal/telemetry): avoid flakiness on telemetry tests fix(internal/telemetry): avoid flakiness on telemetry tests; pin localstack/localstack Mar 23, 2026
@darccio
darccio merged commit a53e802 into main Mar 23, 2026
92 of 94 checks passed
@darccio
darccio deleted the dario.castane/ktlo/incident-51506 branch March 23, 2026 12:03
darccio added a commit that referenced this pull request Mar 27, 2026
@darccio
fix(internal/telemetry): avoid flakiness on telemetry tests; pin `loc…
dc369da 
…alstack/localstack` (#4581)

### What does this PR do?

Avoids flakiness on telemetry tests on `gotip` by disabling
`DependencyLoader` when running them.

Pins `localstack/localstack` to latest known version that doesn't
require license/auth to stabilize CI while we decide how to use it from
now on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

team:apm-go

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darccio @eliottness