Skip to content

fix(tracer): Fix outdated references to tracer.config agentURL and traceProtocol fields#4565

Merged
hannahkm merged 2 commits into
mainfrom
mtoff/fix-outdated-refs
Mar 19, 2026
Merged

fix(tracer): Fix outdated references to tracer.config agentURL and traceProtocol fields#4565
hannahkm merged 2 commits into
mainfrom
mtoff/fix-outdated-refs

Conversation

@mtoffl01

@mtoffl01 mtoffl01 commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes outdated references to agentURL and traceProtocol fields on the tracer's config struct; these fields were removed from the struct in #4550 and replaced by internalConfig access.

Motivation

Fixes bug on main -- Monitor Alert.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

@mtoffl01
mtoffl01 requested a review from a team as a code owner March 19, 2026 17:24
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Mar 19, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.36% (+3.50%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5276dcc | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@hannahkm
hannahkm merged commit 0b8e268 into main Mar 19, 2026
96 of 113 checks passed
@hannahkm
hannahkm deleted the mtoff/fix-outdated-refs branch March 19, 2026 17:42
@pr-commenter

pr-commenter Bot commented Mar 19, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-19 17:44:25

Comparing candidate commit 5276dcc in PR branch mtoff/fix-outdated-refs with baseline commit 0480a77 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 102 metrics, 6 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@hannahkm hannahkm hannahkm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtoffl01 @kakkoyun @hannahkm