Skip to content

feat(internal/log): remove locking#4547

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
dario.castane/atomic-log-level
Mar 17, 2026
Merged

feat(internal/log): remove locking#4547
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
dario.castane/atomic-log-level

Conversation

@darccio

@darccio darccio commented Mar 16, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Turns internal/log to use atomic.Int32 to avoid using log.mu locking when checking the level.

Motivation

Complete #1905 work using the current benchmarking platform.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner March 16, 2026 16:37
@pr-commenter

pr-commenter Bot commented Mar 16, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-16 16:54:26

Comparing candidate commit dc21375 in PR branch dario.castane/atomic-log-level with baseline commit c5afeb0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 157 metrics, 7 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Mar 16, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 80.00%
• Overall Coverage: 59.32% (+3.53%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dc21375 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit e8c42f7 into main Mar 17, 2026
92 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the dario.castane/atomic-log-level branch March 17, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done team:apm-go

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darccio @kakkoyun @eliottness