Skip to content

fix: remove duplicate span tags and test cases in rueidis and valkey-go#4510

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
DataDog:mainfrom
snutiise:fix/cleanup-rueidis-valkey-span-tags
Mar 12, 2026
Merged

fix: remove duplicate span tags and test cases in rueidis and valkey-go#4510
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
DataDog:mainfrom
snutiise:fix/cleanup-rueidis-valkey-span-tags

Conversation

@snutiise

@snutiise snutiise commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Remove duplicate TargetHost/TargetPort span tags and duplicate test cases in contrib/redis/rueidis and contrib/valkey-io/valkey-go.

  • Duplicate span tags: startSpan unconditionally sets TargetHost/TargetPort in the initial options slice, then conditionally appends them again when the values are non-empty. The unconditional entries are removed.
  • Duplicate test cases: Both test files contain two identical copies of "canceled context with custom error check" and "nil not attached to span" test cases. The duplicates are removed.

Motivation

Found during code review of the rueidis/valkey tracing instrumentation. These are pre-existing issues, not regressions.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

@snutiise
snutiise requested review from a team as code owners March 9, 2026 11:42
rarguelloF
rarguelloF approved these changes Mar 12, 2026
View reviewed changes

@rarguelloF rarguelloF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the fixes!

@rarguelloF

rarguelloF commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-12 12:38:48 UTC ℹ️ Start processing command /merge

2026-03-12 12:38:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-03-12 12:50:15 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 29m (p90).

2026-03-12 13:04:22 UTC ℹ️ MergeQueue: This merge request was merged

@darccio

darccio commented Mar 12, 2026

Copy link
Copy Markdown
Member

@codex review

@codecov

codecov Bot commented Mar 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.92%. Comparing base (5160dbf) to head (4e84691).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 264 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Mar 12, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit aa5518d into DataDog:main Mar 12, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@rarguelloF rarguelloF rarguelloF approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snutiise @rarguelloF @darccio