Skip to content

feat: OTel process context v2 (otlp proto)#4478

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
nsavoire/otel_process_context_otlp_proto
Mar 20, 2026
Merged

feat: OTel process context v2 (otlp proto)#4478
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
nsavoire/otel_process_context_otlp_proto

Conversation

@nsavoire

@nsavoire nsavoire commented Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Update OTel process context to v2 (see open-telemetry/opentelemetry-specification#4719)

Motivation

Bring implementation in dd-trace-go up-to-date with proposal.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

JIRA [PROF-14086]

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 27, 2026
@codecov

codecov Bot commented Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.06383% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.44%. Comparing base (6af22e4) to head (0936c38).
⚠️ Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
...nal/otelprocesscontext/otelcontextmapping_linux.go 78.00% 12 Missing and 10 partials ⚠️
internal/otelprocesscontext/processcontext.pb.go 59.61% 20 Missing and 1 partial ⚠️
internal/otelprocesscontext/otelprocesscontext.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
ddtrace/tracer/tracer.go 87.87% <100.00%> (ø)
ddtrace/tracer/tracer_metadata.go 100.00% <100.00%> (ø)
internal/otelprocesscontext/otelprocesscontext.go 60.00% <60.00%> (ø)
internal/otelprocesscontext/processcontext.pb.go 59.61% <59.61%> (ø)
...nal/otelprocesscontext/otelcontextmapping_linux.go 78.00% <78.00%> (ø)

... and 431 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nsavoire nsavoire mentioned this pull request Feb 27, 2026
Closed
9 tasks
@nsavoire
nsavoire force-pushed the nsavoire/otel_process_context_otlp_proto branch 3 times, most recently from 94ef0be to 5a9f7c3 Compare March 2, 2026 21:13
@pr-commenter

pr-commenter Bot commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-20 20:20:25

Comparing candidate commit 82d076b in PR branch nsavoire/otel_process_context_otlp_proto with baseline commit 0751c8a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 216 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@nsavoire
nsavoire force-pushed the nsavoire/otel_process_context_otlp_proto branch from 5a9f7c3 to 024eab3 Compare March 3, 2026 09:28
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Mar 19, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 75.88%
• Overall Coverage: 59.81% (+3.94%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 82d076b | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@nsavoire
nsavoire marked this pull request as ready for review March 19, 2026 11:08
@nsavoire
nsavoire requested review from a team as code owners March 19, 2026 11:08
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Mar 19, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c29b20e307

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/otelprocesscontext/otelprocesscontext.go Outdated
@nsavoire
nsavoire force-pushed the nsavoire/otel_process_context_otlp_proto branch from c29b20e to 0936c38 Compare March 19, 2026 13:02
@nsavoire nsavoire changed the title feat: OTel process context v2 (otlp proto) [PROF-14086] feat: OTel process context v2 (otlp proto) Mar 20, 2026
@nsavoire nsavoire changed the title [PROF-14086] feat: OTel process context v2 (otlp proto) feat: OTel process context v2 (otlp proto) Mar 20, 2026
@nsavoire
nsavoire force-pushed the nsavoire/otel_process_context_otlp_proto branch from 6d82ff1 to 82d076b Compare March 20, 2026 19:55
@nsavoire

nsavoire commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and squashed commits to fix conflicts and clean up history.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit f3970b8 into main Mar 20, 2026
135 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the nsavoire/otel_process_context_otlp_proto branch March 20, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@darccio darccio darccio approved these changes
@mtoffl01 mtoffl01 mtoffl01 approved these changes
@nsrip-dd nsrip-dd nsrip-dd approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nsavoire @darccio @mtoffl01 @nsrip-dd