Skip to content

fix(eventbridge): update max payload size to 1m#4458

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
david.ogbureke/eventbridge-1mb-payload-limit
Mar 19, 2026
Merged

fix(eventbridge): update max payload size to 1m#4458
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
david.ogbureke/eventbridge-1mb-payload-limit

Conversation

@Dogbu-cyber

@Dogbu-cyber Dogbu-cyber commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates the EventBridge max payload size constant from 256KB to 1MB to match the AWS service-side limit increase announced January 2026.

Motivation

https://aws.amazon.com/blogs/compute/more-room-to-build-serverless-services-now-support-payloads-up-to-1-mb/

Trace context injection would be unnecessarily skipping EventBridge entries whose Detail feed lied between 256kb and 1mb.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 20, 2026
@codecov

codecov Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.08%. Comparing base (6af22e4) to head (66c6e24).

Additional details and impacted files
Files with missing lines Coverage Δ
.../aws-sdk-go-v2/internal/eventbridge/eventbridge.go 66.66% <ø> (ø)

... and 387 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov

codecov Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.46%. Comparing base (6af22e4) to head (66c6e24).

Additional details and impacted files
Files with missing lines Coverage Δ
.../aws-sdk-go-v2/internal/eventbridge/eventbridge.go 66.66% <ø> (ø)

... and 373 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-03 16:27:03

Comparing candidate commit d2dc3e2 in PR branch david.ogbureke/eventbridge-1mb-payload-limit with baseline commit 5793394 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 149 metrics, 6 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@codecov

codecov Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.43%. Comparing base (6af22e4) to head (66c6e24).

Additional details and impacted files
Files with missing lines Coverage Δ
.../aws-sdk-go-v2/internal/eventbridge/eventbridge.go 66.66% <ø> (ø)

... and 368 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov

codecov Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@5793394). Learn more about missing BASE report.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

darccio
darccio reviewed Feb 23, 2026
View reviewed changes

@darccio darccio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dogbu-cyber
Dogbu-cyber marked this pull request as ready for review February 23, 2026 16:07
@Dogbu-cyber
Dogbu-cyber requested review from a team as code owners February 23, 2026 16:07
@Dogbu-cyber
Dogbu-cyber force-pushed the david.ogbureke/eventbridge-1mb-payload-limit branch from 66c6e24 to 4af20c8 Compare February 23, 2026 16:15
@Dogbu-cyber
Update eventbridge.go
faa24f1 
Serverless services now support a maximum payload size of 1 mb.
@Dogbu-cyber
Dogbu-cyber force-pushed the david.ogbureke/eventbridge-1mb-payload-limit branch from 4af20c8 to faa24f1 Compare February 26, 2026 16:49
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 87bc7db into main Mar 19, 2026
185 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the david.ogbureke/eventbridge-1mb-payload-limit branch March 19, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dogbu-cyber @darccio