Skip to content

fix(telemetry): data race on SumReaderCloser#4076

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/telemetry-datarace
Oct 27, 2025
Merged

fix(telemetry): data race on SumReaderCloser#4076
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/telemetry-datarace

Conversation

@eliottness

@eliottness eliottness commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix data race: https://github.com/DataDog/dd-trace-go/actions/runs/18784388569/job/53599447492?pr=4071#step:6:241

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
eliottness requested a review from a team as a code owner October 27, 2025 15:16
@eliottness

eliottness commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-27 15:17:11 UTC ℹ️ Start processing command /merge

2025-10-27 15:17:20 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-27 15:46:30 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-27 16:04:35 UTC ℹ️ MergeQueue: This merge request was merged

@pr-commenter

pr-commenter Bot commented Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-27 15:26:19

Comparing candidate commit 139f6f3 in PR branch eliottness/telemetry-datarace with baseline commit 399a58b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@dd-mergequeue
dd-mergequeue Bot merged commit eed890e into main Oct 27, 2025
244 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/telemetry-datarace branch October 27, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@genesor genesor genesor approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliottness @kakkoyun @genesor