Skip to content

feat(appsec): support custom data classification#4074

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
romain.marcadier/custom-data-classification
Oct 27, 2025
Merged

feat(appsec): support custom data classification#4074
dd-mergequeue[bot] merged 2 commits into
mainfrom
romain.marcadier/custom-data-classification

Conversation

@RomainMuller

@RomainMuller RomainMuller commented Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Register the ASM_PROCESSOR_OVERRIDES and ASM_CUSTOM_DATA_SCANNERS so that custom data classification can be used in Go.

ASM-RFC: 1071

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@RomainMuller
feat(appsec): support custom data classification
a1678a4 
Register the `ASM_PROCESSOR_OVERRIDES` and `ASM_CUSTOM_DATA_SCANNERS`
so that custom data classification can be used in Go.

ASM-RFC: 1071
@RomainMuller
RomainMuller requested a review from a team as a code owner October 27, 2025 10:55
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 27, 2025
@RomainMuller RomainMuller mentioned this pull request Oct 27, 2025
Merged
6 tasks
@pr-commenter

pr-commenter Bot commented Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-27 17:02:42

Comparing candidate commit 8905093 in PR branch romain.marcadier/custom-data-classification with baseline commit 9225b43 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness

eliottness commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-27 16:50:30 UTC ℹ️ Start processing command /merge

2025-10-27 16:50:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-27 17:12:36 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-27 17:28:29 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit abd2718 into main Oct 27, 2025
264 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the romain.marcadier/custom-data-classification branch October 27, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RomainMuller @eliottness