chore(profiler): enable shuffle testing#4070
Merged
Merged
Conversation
I haven't been able to reproduce shuffle test failures for the profiler, even after hundreds of runs. The initial failures may have been timing-related flakes due to running many instances of the test suite in parallel. It's probably fine to just enable shuffle testing for the profiler.
genesor
approved these changes
Oct 24, 2025
genesor
left a comment
genesor
left a comment
Member
There was a problem hiding this comment.
We did fix a few flakes recently they might have been related to the failure you had in the past.
BenchmarksBenchmark execution time: 2025-10-24 13:42:55 Comparing candidate commit 46d8598 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't been able to reproduce shuffle test failures for the profiler,
even after hundreds of runs. The initial failures may have been
timing-related flakes due to running many instances of the test suite in
parallel. It's probably fine to just enable shuffle testing for the
profiler.