Skip to content

fix(ddtrace/tracer): don't leak URL details on WithAgentURL failure#4066

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
push-wwqkvxtrmotu
Oct 23, 2025
Merged

fix(ddtrace/tracer): don't leak URL details on WithAgentURL failure#4066
dd-mergequeue[bot] merged 1 commit into
mainfrom
push-wwqkvxtrmotu

Conversation

@darccio

@darccio darccio commented Oct 23, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Avoids leaking URL details on error when running WithAgentURL by not logging the returned err value from url.Parse.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner October 23, 2025 09:20
@darccio darccio mentioned this pull request Oct 23, 2025
Merged
7 tasks
@pr-commenter

pr-commenter Bot commented Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-23 09:35:39

Comparing candidate commit 3db20a5 in PR branch push-wwqkvxtrmotu with baseline commit 9884fb8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

kakkoyun
kakkoyun approved these changes Oct 23, 2025
View reviewed changes

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kakkoyun

kakkoyun commented Oct 23, 2025

Copy link
Copy Markdown
Member

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-23 10:08:04 UTC ℹ️ Start processing command /merge

2025-10-23 10:08:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-23 10:22:02 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 1eb58b4 into main Oct 23, 2025
244 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the push-wwqkvxtrmotu branch October 23, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darccio @kakkoyun