Skip to content

fix(.github/workflows/apps): ignore parsed fetched go.mod#4055

Merged
darccio merged 1 commit into
mainfrom
push-slnrrtpmwuzu
Oct 20, 2025
Merged

fix(.github/workflows/apps): ignore parsed fetched go.mod#4055
darccio merged 1 commit into
mainfrom
push-slnrrtpmwuzu

Conversation

@darccio

@darccio darccio commented Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Ignores the returned parsed go.mod from fetchGoMod as it's unused in Outdated Integrations' script.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner October 20, 2025 08:17
@datadog-official

datadog-official Bot commented Oct 20, 2025 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a188336 | Docs | Was this helpful? Give us feedback!

@pr-commenter

pr-commenter Bot commented Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-20 11:17:15

Comparing candidate commit a188336 in PR branch push-slnrrtpmwuzu with baseline commit 585513f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 0 unstable metrics.

@darccio

darccio commented Oct 20, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-20 11:24:22 UTC ℹ️ Start processing command /merge

2025-10-20 11:24:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-20 11:26:17 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-20 12:28:09 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit ecd85e5:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@darccio
darccio merged commit bddbef7 into main Oct 20, 2025
321 of 326 checks passed
@darccio
darccio deleted the push-slnrrtpmwuzu branch October 20, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes
@cbeauchesne cbeauchesne cbeauchesne approved these changes

Assignees

No one assigned

Labels

mergequeue-status: rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darccio @RomainMuller @cbeauchesne