Skip to content

fix(envoyproxy): replace telemetry header by env var for envoy gateway#4051

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
eliottness/envoy-gateway-telemetry-fix
Oct 17, 2025
Merged

fix(envoyproxy): replace telemetry header by env var for envoy gateway#4051
dd-mergequeue[bot] merged 2 commits into
mainfrom
eliottness/envoy-gateway-telemetry-fix

Conversation

@eliottness

@eliottness eliottness commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR changes the way we get telemetry out of envoy gateway instances because we cannot add the usual custom header using EnvoyExtensionPolicy CRD. Therefore we fall back to only look if we run in kubernetes if we have not found another header we know of

Motivation

Better telemetry

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
eliottness requested a review from a team as a code owner October 16, 2025 13:25
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 16, 2025
@pr-commenter

pr-commenter Bot commented Oct 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-17 09:16:24

Comparing candidate commit b72c9f6 in PR branch eliottness/envoy-gateway-telemetry-fix with baseline commit 9884fb8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

eliottness
eliottness commented Oct 17, 2025
View reviewed changes
Comment thread contrib/envoyproxy/go-control-plane/envoy_messages.go Outdated
@eliottness

eliottness commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-17 09:04:11 UTC ℹ️ Start processing command /merge

2025-10-17 09:04:20 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-17 13:05:10 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

TestHealthMetricsRaceCondition from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog) 
Failed

=== RUN   TestHealthMetricsRaceCondition
    metrics_test.go:272: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/metrics_test.go:272
        	Error:      	Condition never satisfied
        	Test:       	TestHealthMetricsRaceCondition
    metrics_test.go:274: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/metrics_test.go:274
        	Error:      	Should be true
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b72c9f6 | Docs | Was this helpful? Give us feedback!

@eliottness

eliottness commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-17 13:38:09 UTC ℹ️ Start processing command /merge

2025-10-17 13:38:20 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-17 13:49:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-17 14:07:25 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 585513f into main Oct 17, 2025
269 of 273 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/envoy-gateway-telemetry-fix branch October 17, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e-n-0 e-n-0 e-n-0 approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @e-n-0