Skip to content

feat: allow skip-checks with reason#4048

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
push-yttmyonzxkrx
Oct 15, 2025
Merged

feat: allow skip-checks with reason#4048
dd-mergequeue[bot] merged 1 commit into
mainfrom
push-yttmyonzxkrx

Conversation

@darccio

@darccio darccio commented Oct 15, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Enables skip-checks to allow to merge to main when not all checks are green. Handle with care.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner October 15, 2025 09:00
@pr-commenter

pr-commenter Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-15 09:24:56

Comparing candidate commit 204fffd in PR branch push-yttmyonzxkrx with baseline commit 781c7b7 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 0 unstable metrics.

scenario:BenchmarkParallelMetrics/distribution/get-handle-24

  • 🟩 execution_time [-4.060ns; -1.618ns] or [-5.878%; -2.343%]

@darccio

darccio commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-15 09:16:35 UTC ℹ️ Start processing command /merge

2025-10-15 09:16:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-15 09:35:24 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-15 09:47:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit e0e3157 into main Oct 15, 2025
243 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the push-yttmyonzxkrx branch October 15, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@genesor genesor genesor approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darccio @kakkoyun @genesor