Skip to content

feat: add multivalue headers changes from datadog-lambda-go#4047

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
onzia/multivalue-headers
Oct 16, 2025
Merged

feat: add multivalue headers changes from datadog-lambda-go#4047
dd-mergequeue[bot] merged 3 commits into
mainfrom
onzia/multivalue-headers

Conversation

@ojproductions

@ojproductions ojproductions commented Oct 14, 2025 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Copies multivalue header changes made in datadog-lambda-go

Motivation

APMSVLS-226

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@ojproductions
ojproductions requested a review from a team as a code owner October 14, 2025 20:47
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 14, 2025
@ojproductions ojproductions changed the title move changes from datadog-lambda-go into dd-trace-go contrib add multivalue headers changes from datadog-lambda-go Oct 14, 2025
@pr-commenter

pr-commenter Bot commented Oct 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-16 14:08:51

Comparing candidate commit 4e1c1b4 in PR branch onzia/multivalue-headers with baseline commit 9884fb8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@ojproductions ojproductions changed the title add multivalue headers changes from datadog-lambda-go feat; add multivalue headers changes from datadog-lambda-go Oct 14, 2025
@ojproductions ojproductions changed the title feat; add multivalue headers changes from datadog-lambda-go feat: add multivalue headers changes from datadog-lambda-go Oct 14, 2025
joeyzhao2018
joeyzhao2018 approved these changes Oct 15, 2025
View reviewed changes

@joeyzhao2018 joeyzhao2018 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@datadog-official

datadog-official Bot commented Oct 16, 2025 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4e1c1b4 | Docs | Was this helpful? Give us feedback!

@ojproductions

ojproductions commented Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 16, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-16 14:55:03 UTC ℹ️ Start processing command /merge

2025-10-16 14:55:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-16 15:09:07 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit deee68b into main Oct 16, 2025
269 of 273 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the onzia/multivalue-headers branch October 16, 2025 15:09
@xrn

xrn commented Oct 17, 2025

Copy link
Copy Markdown

Hey,

Are there any chances that these changes related to dd-trace-go would be released soon?

@darccio

darccio commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Hello @xrn, thanks for reaching out. dd-trace-go releases follow a monthly cadence. We are currently finishing the previous one that started early September, so this will be included in the next one starting next week, probably available around end of October/early November.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joeyzhao2018 joeyzhao2018 joeyzhao2018 approved these changes

Assignees

@joeyzhao2018 joeyzhao2018

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ojproductions @xrn @darccio @joeyzhao2018