Skip to content

fix(contrib/confluentinc/confluent-kakfa-go/kafka.v2): bump shoenig/go-m1cpu to v0.1.7#4044

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
dario.castane/shoenig-go-m1cpu
Oct 15, 2025
Merged

fix(contrib/confluentinc/confluent-kakfa-go/kafka.v2): bump shoenig/go-m1cpu to v0.1.7#4044
dd-mergequeue[bot] merged 1 commit into
mainfrom
dario.castane/shoenig-go-m1cpu

Conversation

@darccio

@darccio darccio commented Oct 13, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Bumps shoenig/go-m1cpu to the latest available version, as it contains the fix for this warning when compiling with Xcode 26.0 (17A324):

# github.com/shoenig/go-m1cpu
go1.24.2/global/pkg/mod/github.com/shoenig/[email protected]/cpu.go:75:17: warning: variable length array folded to constant array as an extension [-Wgnu-folding-constant]
go1.24.2/global/pkg/mod/github.com/shoenig/[email protected]/cpu.go:77:16: warning: variable length array folded to constant array as an extension [-Wgnu-folding-constant]

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 13, 2025
@pr-commenter

pr-commenter Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-13 16:38:58

Comparing candidate commit 7524660 in PR branch dario.castane/shoenig-go-m1cpu with baseline commit 45246a0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio

darccio commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-15 09:29:24 UTC ℹ️ Start processing command /merge

2025-10-15 09:29:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-15 09:44:27 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit bb736f5 into main Oct 15, 2025
265 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the dario.castane/shoenig-go-m1cpu branch October 15, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rarguelloF rarguelloF rarguelloF approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darccio @rarguelloF