fix(ddtrace/tracer): Implement Serverless Service Representation#4043
Merged
Conversation
rithikanarayan
changed the title
rithikanarayan
changed the title
rithikanarayan
changed the title
ojproductions
force-pushed
the
APMSVLS-39
branch
2 times, most recently
from
October 16, 2025 22:11
54824fb to
10016d7
Compare
ojproductions
marked this pull request as ready for review
October 17, 2025 13:06
zarirhamza
requested changes
Oct 20, 2025
zarirhamza
left a comment
zarirhamza
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, just some code quality changes
ojproductions
force-pushed
the
APMSVLS-39
branch
from
October 20, 2025 15:42
10016d7 to
ffcc27f
Compare
zarirhamza
approved these changes
Oct 21, 2025
zarirhamza
left a comment
zarirhamza
left a comment
Contributor
There was a problem hiding this comment.
LGTM - nice change on the serverless check to improve performance
darccio
approved these changes
Oct 22, 2025
darccio
left a comment
darccio
left a comment
Member
There was a problem hiding this comment.
Approved, but consider @purple4reina's feedback in https://github.com/DataDog/dd-trace-go/pull/4043/files#r2449442341.
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Serverless Service Representation (SSR) for Go.
In serverless environments, sets peer.service tag for AWS managed service spans to {service type}.{region}.amazonaws.com:
Sets peer.service.source to peer.service for these serverless cases.
Adds LambdaFunctionName as field in tracer config to detect serverless cases.
Motivation
Prior to changes:
After changes: View represents customers' mental model of systems better.
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!