Skip to content

chore(codeowners): add ml-observability team#4041

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
rarguelloF/llmobs-codeowners
Oct 9, 2025
Merged

chore(codeowners): add ml-observability team#4041
dd-mergequeue[bot] merged 1 commit into
mainfrom
rarguelloF/llmobs-codeowners

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Sets the @DataDog/ml-observability team as codeowner of the llmobs stuff.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rarguelloF
rarguelloF requested a review from a team as a code owner October 8, 2025 15:06
@pr-commenter

pr-commenter Bot commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-08 15:20:05

Comparing candidate commit 2b28d23 in PR branch rarguelloF/llmobs-codeowners with baseline commit 5603e37 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 1 unstable metrics.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 8, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

TestWrapConsumerGroupHandler from github.com/DataDog/dd-trace-go/contrib/IBM/sarama/v2 (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestWrapConsumerGroupHandler
2025/10/08 15:13:53 Sarama consumer up and running!...
    consumer_group_test.go:146: Message claimed: value = test 1, timestamp = 2025-10-08 15:13:53.576 +0000 UTC, topic = IBM_sarama_TestWrapConsumerGroupHandler
    consumer_group_test.go:88: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/IBM/sarama/consumer_group_test.go:88
        	Error:      	"[
        	            	name: kafka.produce
        	            	tags: map[string]interface {}{"_dd.base_service":"", "_dd.p.tid":"68e67fb100000000", "_dd.profiling.enabled":0, "_dd.top_level":1, "component":"IBM/sarama", "language":"go", "messaging.destination.name":"IBM_sarama_TestWrapConsumerGroupHandler", "messaging.kafka.partition":0, "messaging.system":"kafka", "offset":0, "resource.name":"Produce Topic IBM_sarama_TestWrapConsumerGroupHandler", "service.name":"kafka", "span.kind":"producer", "span.name":"kafka.produce", "span.type":"queue"}
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2b28d23 | Docs | Was this helpful? Give us feedback!

@rarguelloF

rarguelloF commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 9, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-09 07:20:12 UTC ℹ️ Start processing command /merge

2025-10-09 07:20:17 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 19m (p90).

2025-10-09 07:37:15 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit ba91431 into main Oct 9, 2025
267 of 273 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the rarguelloF/llmobs-codeowners branch October 9, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes
+1 more reviewer
@gary-huang gary-huang gary-huang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rarguelloF @darccio @Kyle-Verhoog @gary-huang