Skip to content

fix(.github/workflows): [APMSVLS] Update action/cache to 4.3.0 for lambda integration tests#4037

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
storms/update-actions-cache
Oct 8, 2025
Merged

fix(.github/workflows): [APMSVLS] Update action/cache to 4.3.0 for lambda integration tests#4037
dd-mergequeue[bot] merged 1 commit into
mainfrom
storms/update-actions-cache

Conversation

@jcstorms1

@jcstorms1 jcstorms1 commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates action/cache to the SHA of v4.3.0

Motivation

Failing tests

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@jcstorms1
jcstorms1 requested a review from a team as a code owner October 8, 2025 13:40
@pr-commenter

pr-commenter Bot commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-08 13:51:35

Comparing candidate commit 7bd9d63 in PR branch storms/update-actions-cache with baseline commit 39db6b7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio darccio changed the title [APMSVLS] Update action/cache to 4.3.0 for lambda integration tests fix(.github/workflows): [APMSVLS] Update action/cache to 4.3.0 for lambda integration tests Oct 8, 2025
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 8, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

⚠️ Tests

⚠️ Warnings

❄️ 2 New flaky tests detected

TestAsyncSpanRace from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestAsyncSpanRace
=== RUN   TestAsyncSpanRace/#00
fatal error: concurrent map iteration and map write

goroutine 6276 [running]:
internal/runtime/maps.fatal({0x134e2dd?, 0xc00009e540?})
	/opt/hostedtoolcache/go/1.25.2/x64/src/runtime/panic.go:1046 +0x18
internal/runtime/maps.(*Iter).Next(0xc00044ef60?)
...
TestAsyncSpanRace/#00 from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestAsyncSpanRace/#00
fatal error: concurrent map iteration and map write

goroutine 6276 [running]:
internal/runtime/maps.fatal({0x134e2dd?, 0xc00009e540?})
	/opt/hostedtoolcache/go/1.25.2/x64/src/runtime/panic.go:1046 +0x18
internal/runtime/maps.(*Iter).Next(0xc00044ef60?)
	/opt/hostedtoolcache/go/1.25.2/x64/src/internal/runtime/maps/table.go:792 +0x86
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7bd9d63 | Docs | Was this helpful? Give us feedback!

@darccio

darccio commented Oct 8, 2025

Copy link
Copy Markdown
Member

/merge --skip-checks --reason="Testing it on a PR with a flaky tests and completely unrelated changes"

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 14:04:15 UTC ℹ️ Start processing command /merge --skip-checks --reason="Testing it on a PR with a flaky tests and completely unrelated changes"
If you need support, contact us on Slack #devflow!

2025-10-08 14:04:16 UTC ❌ Devflow: /merge --skip-checks --reason="Testing it on a PR with a flaky tests and completely unrelated changes"

Arguments errors:

If you need support, contact us on Slack #devflow with those details!

@darccio

darccio commented Oct 8, 2025

Copy link
Copy Markdown
Member

/merge

1 similar comment
@jcstorms1

jcstorms1 commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 14:09:42 UTC ℹ️ Start processing command /merge

2025-10-08 14:09:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-08 14:23:49 UTC ℹ️ MergeQueue: This merge request was merged

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 14:09:43 UTC ℹ️ Start processing command /merge

2025-10-08 14:09:48 UTC 🚨 Merge Queue: pull request can't be queued

error adding merge request

Details 
child workflow execution error (type: devflow.Devflow_MergePullRequest, workflowID: c76e7f4e-5f0f-42df-8c2d-00a432f75d25_43, runID: eecd583e-efa2-411b-939d-345814946cc4, initiatedEventID: 43, startedEventID: 44): child workflow execution error (type: mergequeue.MergeQueue_QueueMergeRequest, workflowID: eecd583e-efa2-411b-939d-345814946cc4_14, runID: d4b231cf-47de-4204-a439-9d277b26dbfd, initiatedEventID: 14, startedEventID: 15): child workflow execution error (type: mergequeue_private.MergeQueue_CheckAndQueueMergeRequest, workflowID: d4b231cf-47de-4204-a439-9d277b26dbfd_8, runID: 430d4da3-7fd1-4a36-882e-ce04c4be2426, initiatedEventID: 8, startedEventID: 9): child workflow execution error (type: mergequeue_private.MergeQueue_AddOrUpdateMergeRequestInDB, workflowID: 430d4da3-7fd1-4a36-882e-ce04c4be2426_50, runID: c2ce9c16-c06f-4c61-8e70-d0744bcd69e2, initiatedEventID: 50, startedEventID: 51): activity error (type: mergequeue_private.MergeQueue_AddMergeRequestInDB, scheduledEventID: 14, startedEventID: 15, identity: 1@mergequeue-worker-dd6977686-6zbz2@): error adding merge request (type: ErrorMergeRequestAlreadyExist, retryable: false): mergerequest exists already

@dd-mergequeue
dd-mergequeue Bot merged commit 68ec9ae into main Oct 8, 2025
269 of 274 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the storms/update-actions-cache branch October 8, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcstorms1 @darccio