Skip to content

feat(envoyproxy): give the option to manipule gRPC TLS#4035

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
eliottness/envoy-tls
Oct 8, 2025
Merged

feat(envoyproxy): give the option to manipule gRPC TLS#4035
dd-mergequeue[bot] merged 3 commits into
mainfrom
eliottness/envoy-tls

Conversation

@eliottness

@eliottness eliottness commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Give more options to control TLS parameters

Motivation

Support for Envoy Gateway since it does not allow self-signed certs OOTB

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 8, 2025
@eliottness
eliottness marked this pull request as ready for review October 8, 2025 11:43
@eliottness
eliottness requested review from a team as code owners October 8, 2025 11:43
@pr-commenter

pr-commenter Bot commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-08 12:11:26

Comparing candidate commit 23668dc in PR branch eliottness/envoy-tls with baseline commit 5507d97 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

e-n-0
e-n-0 approved these changes Oct 8, 2025
View reviewed changes

@e-n-0 e-n-0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!
However I remember @genesor wanting to have all environment variables tested. You can find tests inside the main_test.go file.

@datadog-official

This comment has been minimized.

Sign in to view
@eliottness
apply @e-n-0 suggestions
23668dc 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness

eliottness commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 12:01:03 UTC ℹ️ Start processing command /merge

2025-10-08 12:01:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-08 12:23:21 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-08 12:39:24 UTC ℹ️ MergeQueue: This merge request was merged

@eliottness
eliottness removed the request for review from rachelyangdog October 8, 2025 12:01
@dd-mergequeue
dd-mergequeue Bot merged commit e65b45a into main Oct 8, 2025
238 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/envoy-tls branch October 8, 2025 12:39
eliottness added a commit that referenced this pull request Nov 4, 2025
@eliottness
feat(envoyproxy): give the option to manipule gRPC TLS (#4035)
0c96174 
Signed-off-by: Eliott Bouhana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genesor genesor genesor approved these changes
@e-n-0 e-n-0 e-n-0 approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliottness @genesor @e-n-0