Skip to content

fix(llmobs/dataset): add pagination and big datasets support#4032

Closed
rarguelloF wants to merge 42 commits into
mainfrom
10-07-fix_llmobs_dataset_add_pagination_and_big_datasets_support
Closed

fix(llmobs/dataset): add pagination and big datasets support#4032
rarguelloF wants to merge 42 commits into
mainfrom
10-07-fix_llmobs_dataset_add_pagination_and_big_datasets_support

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Oct 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Implements pagination when pulling dataset records. This is necessary for big datasets to work.
  • Uses an alternative BulkUploadDataset endpoint for datasets >5MB
  • Increases timeouts for these specific endpoints and removes global http client timeouts

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rarguelloF
feat(llmobs): add LLM Observability SDK
890e929
@rarguelloF
WIP: fixes on dne
9c493ee
@rarguelloF
fix path for unix data socket
00310d9
@rarguelloF
wip: llmobs spans
3497dff
@rarguelloF
fix llmobs span payload
e7409cf
@rarguelloF
integrate llmobs in the tracer
0fa7de7
@rarguelloF
distributed context propagation + tests
79bd066
@rarguelloF
fix context propagation
1cfadb9
@rarguelloF
annotation api
baddd39
@rarguelloF
fixes
4b62c89
@rarguelloF
add RequestDelay option
309d9f7
@rarguelloF
performance improvements
312deff
@rarguelloF
refactor payload names
5e1c1aa
@rarguelloF
Merge branch 'main' into rarguelloF/AIDM-708/llmobs-client
d9027c0
@rarguelloF
update go.mod
98f13b2
@rarguelloF
add tests
d20ed62
@rarguelloF
update configurations
8703018
@rarguelloF
tests and bug fixes
2524cc8
@rarguelloF
add godoc
7bb674b
@rarguelloF
add eval metrics
992fe96
@rarguelloF
fix metrics and nil handling
2004aa1
@rarguelloF
add tests
e08f61f
@rarguelloF
add go docs
d44e46c
@rarguelloF
fix tests
0932552
@rarguelloF
fix lint
ef1ed27
@rarguelloF
add experiments tests
8422022
@rarguelloF
add dataset tests
82037f5
@rarguelloF
Merge branch 'main' into rarguelloF/AIDM-708/llmobs-client
f0d95db
@rarguelloF
fix lint
5cb7913
@rarguelloF
fix typo
dd2b35c
This was referenced Oct 7, 2025
Merged
Merged
Merged
@rarguelloF Graphite App

rarguelloF commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rarguelloF
rarguelloF marked this pull request as ready for review October 7, 2025 16:24
@rarguelloF
rarguelloF requested a review from a team as a code owner October 7, 2025 16:24
@pr-commenter

pr-commenter Bot commented Oct 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-07 16:27:10

Comparing candidate commit ab5a3fe in PR branch 10-07-fix_llmobs_dataset_add_pagination_and_big_datasets_support with baseline commit 824dc80 in branch rarguelloF/AIDM-708/llmobs-client.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Base automatically changed from rarguelloF/AIDM-708/llmobs-client to main October 8, 2025 14:53
@dd-mergequeue
dd-mergequeue Bot requested review from a team as code owners October 8, 2025 14:53
@dd-mergequeue
dd-mergequeue Bot requested a review from genesor October 8, 2025 14:53
@rarguelloF

rarguelloF commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

reopened here: #4039

@rarguelloF rarguelloF closed this Oct 8, 2025
@rarguelloF
rarguelloF deleted the 10-07-fix_llmobs_dataset_add_pagination_and_big_datasets_support branch October 8, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genesor genesor Awaiting requested review from genesor genesor is a code owner automatically assigned from DataDog/apm-sdk-capabilities-go

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rarguelloF @darccio