Skip to content

feat(envoyproxy): report envoy gateway futur integration correctly#4026

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/envoy-gateway-component
Oct 6, 2025
Merged

feat(envoyproxy): report envoy gateway futur integration correctly#4026
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/envoy-gateway-component

Conversation

@eliottness

@eliottness eliottness commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Report a different component when the header x-datadog-envoy-gateway-integration is sent with the extproc request

Motivation

Futur envoy gateway documentation telemetry

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 6, 2025
@pr-commenter

pr-commenter Bot commented Oct 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-06 12:44:59

Comparing candidate commit 9104f89 in PR branch eliottness/envoy-gateway-component with baseline commit cdf3b44 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 6, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

⚠️ Tests

⚠️ Warnings

❄️ 4 New flaky tests detected

TestHealthMetricsRaceCondition from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestHealthMetricsRaceCondition
    metrics_test.go:263: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/metrics_test.go:263
        	Error:      	Condition never satisfied
        	Test:       	TestHealthMetricsRaceCondition
    metrics_test.go:265: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/metrics_test.go:265
        	Error:      	Should be true
...
TestSpansStartedTags from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestSpansStartedTags
--- FAIL: TestSpansStartedTags (1.02s)
TestSpansStartedTags/default from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestSpansStartedTags/default
    metrics_test.go:107: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/metrics_test.go:107
        	Error:      	Condition never satisfied
        	Test:       	TestSpansStartedTags/default
    metrics_test.go:113: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/metrics_test.go:113
        	Error:      	Not equal: 
...
TestFetchCommitData from github.com/DataDog/dd-trace-go/v2/internal/civisibility/utils (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestFetchCommitData
2025/10/06 12:36:59 Datadog Tracer v2.4.0-dev ERROR: civisibility: error decoding environmental data from C:UsersRUNNER~1AppDataLocalTempenvtest767849989testbinary.env.json: invalid character 'i' looking for beginning of object key string (occurred: 06 Oct 25 12:35 UTC)
    git_test.go:95: Failed to fetch commit data for SHA: 8ce5698712353801ab4b84fb46807afdff7c5152, error: civisibility.fetchCommitData: error: exit status 128
        remote: Internal Server Error
        fatal: unable to access 'https://github.com/DataDog/dd-trace-go/': The requested URL returned error: 500
--- FAIL: TestFetchCommitData (131.13s)
View all

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9104f89 | Docs | Was this helpful? Give us feedback!

@eliottness
eliottness marked this pull request as ready for review October 6, 2025 12:53
@eliottness
eliottness requested a review from a team as a code owner October 6, 2025 12:53
@eliottness

eliottness commented Oct 6, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 6, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-06 12:53:46 UTC ℹ️ Start processing command /merge

2025-10-06 12:53:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-06 13:16:23 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 20m (p90).

2025-10-06 13:32:22 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit a4e824b into main Oct 6, 2025
264 of 270 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/envoy-gateway-component branch October 6, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e-n-0 e-n-0 e-n-0 approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @e-n-0