Skip to content

fix(llmobs/dataset): input and metadata can be any type#4024

Merged
rarguelloF merged 1 commit into
rarguelloF/AIDM-708/llmobs-clientfrom
10-06-fix_input_and_metadata_can_be_any_type
Oct 7, 2025
Merged

fix(llmobs/dataset): input and metadata can be any type#4024
rarguelloF merged 1 commit into
rarguelloF/AIDM-708/llmobs-clientfrom
10-06-fix_input_and_metadata_can_be_any_type

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Dataset input and metadata can be any type, not only map[string]any

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

rarguelloF commented Oct 6, 2025

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rarguelloF
rarguelloF marked this pull request as ready for review October 6, 2025 10:44
@rarguelloF
rarguelloF requested a review from a team as a code owner October 6, 2025 10:44
@pr-commenter

pr-commenter Bot commented Oct 6, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-06 10:57:02

Comparing candidate commit ea3971e in PR branch 10-06-fix_input_and_metadata_can_be_any_type with baseline commit 5e06085 in branch rarguelloF/AIDM-708/llmobs-client.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@rarguelloF rarguelloF changed the title fix: input and metadata can be any type fix(llmobs/dataset): input and metadata can be any type Oct 6, 2025
@rarguelloF
rarguelloF merged commit bfdf029 into rarguelloF/AIDM-708/llmobs-client Oct 7, 2025
240 checks passed
@rarguelloF
rarguelloF deleted the 10-06-fix_input_and_metadata_can_be_any_type branch October 7, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants