fix(instrumentation): restore deleted net/http/pattern package (#4017 backport)#4019
Merged
darccio merged 5 commits intoOct 7, 2025
Merged
Conversation
…backport) The instrumentation/net/http/pattern package was moved by #3853. The contrib/net/http/v2 module depends on that package at version v2.2.3. As a result, that verison of contrib/net/http/v2 won't be able to use newer versions of the main module. This is a breaking change. This commit restores the deleted package. While the current contrib/net/http/v2 package doesn't use it any more, this maintains compatibility with previous versions. In this backport, we don't have the NewSafeError functionality for telemetry logging. Rather than bring it back to this branch, this commit just uses the `%T` formatter to get roughly the same functionality. Backports #4017
BenchmarksBenchmark execution time: 2025-10-07 13:01:13 Comparing candidate commit fabb10c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
nsrip-dd
marked this pull request as ready for review
October 6, 2025 14:39
darccio
approved these changes
Oct 6, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instrumentation/net/http/pattern package was moved by #3853. The
contrib/net/http/v2 module depends on that package at version v2.2.3. As a
result, that verison of contrib/net/http/v2 won't be able to use newer
versions of the main module. This is a breaking change. This commit restores the
deleted package. While the current contrib/net/http/v2 package doesn't use it
any more, this maintains compatibility with previous versions.
In this backport, we don't have the NewSafeError functionality for
telemetry logging. Rather than bring it back to this branch, this commit
just uses the
%Tformatter to get roughly the same functionality.Backports #4017