Skip to content

fix(contrib/net/http): WithStatusCheck option#4018

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
ben.db/APMS-17311-fix-status-check-in-roundtripper
Oct 3, 2025
Merged

fix(contrib/net/http): WithStatusCheck option#4018
dd-mergequeue[bot] merged 2 commits into
mainfrom
ben.db/APMS-17311-fix-status-check-in-roundtripper

Conversation

@genesor

@genesor genesor commented Oct 2, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR removes the duplicate IsStatusError in RoundTripperConfig de-facto fixing the WithStatusCheck option.

The IsStatusError function being present in both RoundTripperConfig and CommonConfig caused the CommonConfig one to never be used.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@genesor
genesor requested review from a team as code owners October 2, 2025 15:02
@genesor
genesor force-pushed the ben.db/APMS-17311-fix-status-check-in-roundtripper branch from 7220ec3 to 81a265c Compare October 2, 2025 15:03
@pr-commenter

pr-commenter Bot commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-02 16:06:47

Comparing candidate commit c148162 in PR branch ben.db/APMS-17311-fix-status-check-in-roundtripper with baseline commit ad0205e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 2, 2025
@datadog-official

This comment has been minimized.

Sign in to view
@genesor

genesor commented Oct 3, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 3, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-03 10:29:43 UTC ℹ️ Start processing command /merge

2025-10-03 10:29:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 20m (p90).

2025-10-03 10:42:35 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit e3f00fd into main Oct 3, 2025
331 of 338 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the ben.db/APMS-17311-fix-status-check-in-roundtripper branch October 3, 2025 10:42
darccio pushed a commit that referenced this pull request Oct 20, 2025
@genesor @darccio
fix(contrib/net/http): WithStatusCheck option (#4018)
5abc658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@genesor @darccio