fix(instrumentation): restore deleted net/http/pattern package#4017
Merged
Conversation
nsrip-dd
force-pushed
the
nick.ripley/restore-net-http-pattern
branch
2 times, most recently
from
October 2, 2025 14:45
a1068f8 to
1c82e8f
Compare
BenchmarksBenchmark execution time: 2025-10-02 16:58:52 Comparing candidate commit cb7248e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
nsrip-dd
force-pushed
the
nick.ripley/restore-net-http-pattern
branch
from
October 2, 2025 14:58
1c82e8f to
7463f7c
Compare
nsrip-dd
marked this pull request as ready for review
October 2, 2025 15:46
kakkoyun
approved these changes
Oct 2, 2025
nsrip-dd
force-pushed
the
nick.ripley/restore-net-http-pattern
branch
from
October 2, 2025 15:55
7463f7c to
05f28f2
Compare
The instrumentation/net/http/pattern package was moved by #3853. The contribu/net/http/v2 module depends on that package at version v2.2.3. As a result, that verison of contrib/net/http/v2 won't be able to use newer versions of the main module. This is a breaking change. This commit restores the deleted package. While the current contrib/net/http/v2 package doesn't use it any more, this maintains compatibility with previous versions.
nsrip-dd
force-pushed
the
nick.ripley/restore-net-http-pattern
branch
from
October 2, 2025 16:42
05f28f2 to
cb7248e
Compare
nsrip-dd
enabled auto-merge (squash)
October 2, 2025 16:48
nsrip-dd
added a commit
that referenced
this pull request
Oct 2, 2025
…backport) The instrumentation/net/http/pattern package was moved by #3853. The contrib/net/http/v2 module depends on that package at version v2.2.3. As a result, that verison of contrib/net/http/v2 won't be able to use newer versions of the main module. This is a breaking change. This commit restores the deleted package. While the current contrib/net/http/v2 package doesn't use it any more, this maintains compatibility with previous versions. In this backport, we don't have the NewSafeError functionality for telemetry logging. Rather than bring it back to this branch, this commit just uses the `%T` formatter to get roughly the same functionality. Backports #4017
darccio
added a commit
that referenced
this pull request
Oct 7, 2025
…backport) (#4019) Co-authored-by: Hannah Kim <[email protected]> Co-authored-by: Dario Castañé <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
instrumentation/net/http/patternpackage was moved by #3853. Thecontrib/net/http/v2module depends on that package at version v2.2.3. As aresult, that verison of
contrib/net/http/v2won't be able to use newerversions of the main module. This is a breaking change. This PR restores the
deleted package. While the current
contrib/net/http/v2package doesn't use itany more, this maintains compatibility with previous versions.