fix(profiler): switch back to pre-zstd compression#4016
Merged
Conversation
After switching our default compression to zstd, we've found that the profiler's memory usage is too high for some internal services. The memory usage primarily comes from the compression library's history buffer, which defaults to 8MiB (see the zstd.WithWindowSize option.) We have one compressor per profile type. For now we'll switch back to the "legacy" compression scheme by default. Users can opt back in to zstd by setting DD_PROFILING_DEBUG_COMPRESSION_SETTINGS=zstd.
BenchmarksBenchmark execution time: 2025-10-02 13:01:31 Comparing candidate commit 7b9a862 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
felixge
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After switching our default compression to zstd, we've found that the
profiler's memory usage is too high for some internal services. The
memory usage primarily comes from the compression library's history
buffer, which defaults to 8MiB (see the
zstd.WithWindowSizeoption.) Wehave one compressor per profile type. For now we'll switch back to the
"legacy" compression scheme by default. Users can opt back in to zstd by
setting
DD_PROFILING_DEBUG_COMPRESSION_SETTINGS=zstd.