Skip to content

fix(contrib): ensure that go docs are properly generated#4015

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
dario.castane/fix-contrib-listing
Oct 15, 2025
Merged

fix(contrib): ensure that go docs are properly generated#4015
dd-mergequeue[bot] merged 3 commits into
mainfrom
dario.castane/fix-contrib-listing

Conversation

@darccio

@darccio darccio commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Retracts v0.0.0-20240516153256-8d6fa2bea61d and adds a warning about how to import v2 contribs.

Motivation

Fixes #4012.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested review from a team as code owners October 2, 2025 09:14
@darccio darccio changed the title Dario.castane/fix contrib listing fix(contrib): ensure that go docs are properly generated Oct 2, 2025
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 2, 2025
@pr-commenter

pr-commenter Bot commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-02 09:32:10

Comparing candidate commit ec9a5a1 in PR branch dario.castane/fix-contrib-listing with baseline commit ad0205e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

genesor
genesor reviewed Oct 2, 2025
View reviewed changes
Comment thread go.mod
retract (
[v2.0.0-rc.1, v2.0.0-rc.22]
[v2.0.0-beta.1, v2.0.0-beta.11]
v2.0.0-20240516153256-8d6fa2bea61d

@genesor genesor Oct 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to retract v0.0.0-20240516153256-8d6fa2bea61d ?

@darccio darccio Oct 3, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@genesor I do, but you can't retract a v0 in a v2 go.mod.

@kakkoyun

kakkoyun commented Oct 15, 2025

Copy link
Copy Markdown
Member

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-15 13:13:41 UTC ℹ️ Start processing command /merge

2025-10-15 13:13:45 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-15 13:29:50 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 9884fb8 into main Oct 15, 2025
259 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the dario.castane/fix-contrib-listing branch October 15, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@genesor genesor genesor approved these changes
@rarguelloF rarguelloF rarguelloF approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: v2.2.3 does not contain package github.com/DataDog/dd-trace-go/v2/contrib/gorm.io/gorm.v1

4 participants

@darccio @kakkoyun @genesor @rarguelloF