Skip to content

feat: enable process tags by default#4008

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
raphael/process_tags_default
Oct 8, 2025
Merged

feat: enable process tags by default#4008
dd-mergequeue[bot] merged 3 commits into
mainfrom
raphael/process_tags_default

Conversation

@raphaelgavache

@raphaelgavache raphaelgavache commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Setting process tags collection on by default

The process tag collection is already enabled on couple go applications, and is on by default for the java tracer on many many applications. (on my default on jvm 21 for 1.53.0, always on by default for 1.54+)

matching system tests: DataDog/system-tests#5382

next follow-ups

  • add tags in runtime metrics
  • support container back propagation for DSM/DBM

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@raphaelgavache raphaelgavache changed the title enable process tags by default feat: enable process tags by default Sep 30, 2025
@pr-commenter

pr-commenter Bot commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-07 15:12:43

Comparing candidate commit a82ec2a in PR branch raphael/process_tags_default with baseline commit 23545d4 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 4 metrics, 0 unstable metrics.

scenario:BenchmarkOTelApiWithCustomTags/datadog_otel_api-24

  • 🟥 allocated_mem [+387 bytes; +396 bytes] or [+11.422%; +11.676%]

scenario:BenchmarkOTelApiWithCustomTags/otel_api-24

  • 🟥 allocated_mem [+387 bytes; +396 bytes] or [+8.213%; +8.397%]

@raphaelgavache raphaelgavache added core enhancement quick change/addition that does not need full team approval performance/ignore-performance-regression labels Sep 30, 2025
@raphaelgavache
raphaelgavache marked this pull request as ready for review October 1, 2025 00:16
@raphaelgavache
raphaelgavache requested review from a team as code owners October 1, 2025 00:16
@raphaelgavache raphaelgavache mentioned this pull request Oct 1, 2025
Merged
7 tasks
kakkoyun
kakkoyun approved these changes Oct 2, 2025
View reviewed changes

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphaelgavache
raphaelgavache force-pushed the raphael/process_tags_default branch from a22f108 to 089938e Compare October 7, 2025 15:04
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 7, 2025 •
edited
Loading

Copy link
Copy Markdown

⚠️ Tests

⚠️ Warnings

❄️ 2 New flaky tests detected

TestSpansFinishedTags from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestSpansFinishedTags
--- FAIL: TestSpansFinishedTags (0.21s)
TestSpansFinishedTags/custom_integration from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestSpansFinishedTags/custom_integration
    statsdtest.go:327: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/internal/statsdtest/statsdtest.go:327
        	            				/home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/metrics_test.go:175
        	Error:      	Condition never satisfied
        	Test:       	TestSpansFinishedTags/custom_integration
    --- FAIL: TestSpansFinishedTags/custom_integration (0.16s)

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a82ec2a | Docs | Was this helpful? Give us feedback!

@raphaelgavache

raphaelgavache commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 13:16:49 UTC ℹ️ Start processing command /merge

2025-10-08 13:16:55 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-08 13:31:55 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 39db6b7 into main Oct 8, 2025
265 of 269 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the raphael/process_tags_default branch October 8, 2025 13:31
@wantsui wantsui mentioned this pull request Mar 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@piochelepiotr piochelepiotr piochelepiotr approved these changes
@mtoffl01 mtoffl01 mtoffl01 approved these changes
@nsrip-dd nsrip-dd nsrip-dd approved these changes
@rachelyangdog rachelyangdog Awaiting requested review from rachelyangdog rachelyangdog is a code owner automatically assigned from DataDog/apm-sdk-capabilities-go

Assignees

No one assigned

Labels

core enhancement quick change/addition that does not need full team approval mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@raphaelgavache @kakkoyun @piochelepiotr @mtoffl01 @nsrip-dd