Skip to content

chore: lambda integration tests updates#4007

Merged
dd-mergequeue[bot] merged 12 commits into
mainfrom
APMSVLS-184
Oct 10, 2025
Merged

chore: lambda integration tests updates#4007
dd-mergequeue[bot] merged 12 commits into
mainfrom
APMSVLS-184

Conversation

@joeyzhao2018

@joeyzhao2018 joeyzhao2018 commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Some fixes and updates to the lambda integration tests

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 30, 2025
@pr-commenter

pr-commenter Bot commented Sep 30, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-09 15:59:04

Comparing candidate commit bce4a1d in PR branch APMSVLS-184 with baseline commit 01837b8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 2, 2025

Copy link
Copy Markdown

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

TestWrapConsumerGroupHandler from github.com/DataDog/dd-trace-go/contrib/IBM/sarama/v2 (Datadog) (✨ Fix with BitsAI)
Failed

=== RUN   TestWrapConsumerGroupHandler
2025/10/09 15:50:24 Sarama consumer up and running!...
    consumer_group_test.go:146: Message claimed: value = test 1, timestamp = 2025-10-09 15:50:24.764 +0000 UTC, topic = IBM_sarama_TestWrapConsumerGroupHandler
    consumer_group_test.go:88: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/IBM/sarama/consumer_group_test.go:88
        	Error:      	"[
        	            	name: kafka.produce
        	            	tags: map[string]interface {}{"_dd.base_service":"", "_dd.p.tid":"68e7d9c000000000", "_dd.profiling.enabled":0, "_dd.top_level":1, "component":"IBM/sarama", "language":"go", "messaging.destination.name":"IBM_sarama_TestWrapConsumerGroupHandler", "messaging.kafka.partition":0, "messaging.system":"kafka", "offset":0, "resource.name":"Produce Topic IBM_sarama_TestWrapConsumerGroupHandler", "service.name":"kafka", "span.kind":"producer", "span.name":"kafka.produce", "span.type":"queue"}
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bce4a1d | Docs | Was this helpful? Give us feedback!

@joeyzhao2018 joeyzhao2018 changed the title lambda integration tests updates chore: lambda integration tests updates Oct 3, 2025
@joeyzhao2018
joeyzhao2018 marked this pull request as ready for review October 3, 2025 19:15
@joeyzhao2018
joeyzhao2018 requested review from a team as code owners October 3, 2025 19:15
Comment on lines +26 to +27
log.Println("Current span ID: " + strconv.FormatUint(currentSpanContext.SpanID(), 10))
log.Println("Current trace ID: " + currentSpanContext.TraceID())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use log/slog -- it's more performant and cleaner, iirc

@joeyzhao2018
joeyzhao2018 requested a review from hannahkm October 8, 2025 15:27
@joeyzhao2018

Copy link
Copy Markdown
Contributor Author

@joeyzhao2018

Copy link
Copy Markdown
Contributor Author

/merge

1 similar comment
@joeyzhao2018

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 18:33:25 UTC ℹ️ Start processing command /merge


2025-10-08 18:33:30 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 19m (p90).


2025-10-08 18:47:21 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit c4c4998:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 18:35:42 UTC ℹ️ Start processing command /merge


2025-10-08 18:35:45 UTC ❌ MergeQueue

PR already in the queue with status in_progress

@joeyzhao2018

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 18:55:42 UTC ℹ️ Start processing command /merge


2025-10-08 18:55:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 19m (p90).


2025-10-08 19:07:33 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit c12909e:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@joeyzhao2018

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 9, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-09 15:27:57 UTC ℹ️ Start processing command /merge


2025-10-09 15:28:02 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-10-09 19:29:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@joeyzhao2018

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 10, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-10 01:46:04 UTC ℹ️ Start processing command /merge


2025-10-10 01:46:13 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-10-10 01:58:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).


2025-10-10 02:15:05 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants