Skip to content

fix(ddtrace/tracer): don't fail on error when starting statsd client#4006

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
dario.castane/dont-fail-on-statsd-client-creation
Sep 30, 2025
Merged

fix(ddtrace/tracer): don't fail on error when starting statsd client#4006
dd-mergequeue[bot] merged 1 commit into
mainfrom
dario.castane/dont-fail-on-statsd-client-creation

Conversation

@darccio

@darccio darccio commented Sep 30, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Reverts the behaviour of the statsd client initialization when creating the tracer to the old behaviour in v1:

statsd, err := newStatsdClient(c)
if err != nil {
	log.Warn("Runtime and health metrics disabled: %v", err)
}

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested review from a team as code owners September 30, 2025 11:02
@darccio
darccio requested a review from mtoffl01 September 30, 2025 11:02
@darccio

darccio commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

@codex review

@pr-commenter

pr-commenter Bot commented Sep 30, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-30 11:14:11

Comparing candidate commit 7b5bee9 in PR branch dario.castane/dont-fail-on-statsd-client-creation with baseline commit f253255 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@darccio

darccio commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 30, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-30 14:27:46 UTC ℹ️ Start processing command /merge


2025-09-30 14:27:52 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).


2025-09-30 14:39:50 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 2997dc9 into main Sep 30, 2025
241 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the dario.castane/dont-fail-on-statsd-client-creation branch September 30, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants