fix(contrib/envoy): fix response body processing#4001
Merged
dd-mergequeue[bot] merged 1 commit intoOct 1, 2025
Conversation
github-actions
Bot
added
the
apm:ecosystem
e-n-0
changed the title
BenchmarksBenchmark execution time: 2025-09-30 16:54:16 Comparing candidate commit 4c425f1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
e-n-0
force-pushed
the
flavien/proxy/fix-envoy-resbody-processing
branch
from
September 30, 2025 16:35
9f22275 to
08a6c23
Compare
e-n-0
force-pushed
the
flavien/proxy/fix-envoy-resbody-processing
branch
from
September 30, 2025 16:37
08a6c23 to
4c425f1
Compare
e-n-0
marked this pull request as ready for review
September 30, 2025 16:37
eliottness
approved these changes
Sep 30, 2025
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
Bot
deleted the
flavien/proxy/fix-envoy-resbody-processing
branch
October 1, 2025 08:07
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR identified a bug in the body processing of the Envoy contrib and fixed it.
Motivation
A bug was identified while investigated another issue with body processing. We discovered that the message sent to Envoy to override the processing mode to receive the body, was not properly set (Request was used instead of Response).
Unit tests testing with API Security schema have been added to validate that all bodies are received and sent to the WAF in different condition.
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!