Skip to content

chore(ci): replace TELEMETRY_METRIC_GENERATION_ENABLED with AGENT_SUPPORTING_SPAN_EVENTS from system-tests#3992

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
alejandro.gonzalez/AGENT_SUPPORTING_SPAN_EVENTS
Sep 29, 2025
Merged

chore(ci): replace TELEMETRY_METRIC_GENERATION_ENABLED with AGENT_SUPPORTING_SPAN_EVENTS from system-tests#3992
dd-mergequeue[bot] merged 3 commits into
mainfrom
alejandro.gonzalez/AGENT_SUPPORTING_SPAN_EVENTS

Conversation

@jandro996

@jandro996 jandro996 commented Sep 25, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Replace TELEMETRY_METRIC_GENERATION_ENABLED with AGENT_SUPPORTING_SPAN_EVENTS from system-tests

Motivation

It has been merged into AGENT_SUPPORTING_SPAN_EVENTS DataDog/system-tests#5315

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@jandro996
jandro996 requested a review from a team as a code owner September 25, 2025 12:35
@jandro996

jandro996 commented Sep 25, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 25, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-25 13:36:17 UTC ℹ️ Start processing command /merge

2025-09-25 13:36:23 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 17m (p90).

2025-09-25 13:48:09 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 9aca3ef:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@pr-commenter

pr-commenter Bot commented Sep 26, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-29 10:52:48

Comparing candidate commit 0542f57 in PR branch alejandro.gonzalez/AGENT_SUPPORTING_SPAN_EVENTS with baseline commit 9240604 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@jandro996

jandro996 commented Sep 29, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 29, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-29 11:48:49 UTC ℹ️ Start processing command /merge

2025-09-29 11:48:55 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-09-29 12:03:52 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit c0c5e01 into main Sep 29, 2025
238 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the alejandro.gonzalez/AGENT_SUPPORTING_SPAN_EVENTS branch September 29, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jandro996 @darccio