Skip to content

chore(ci): removes APPSEC_BLOCKING from system-tests#3988

Merged
eliottness merged 5 commits into
mainfrom
cbeauchesne/APPSEC_BLOCKING
Sep 24, 2025
Merged

chore(ci): removes APPSEC_BLOCKING from system-tests#3988
eliottness merged 5 commits into
mainfrom
cbeauchesne/APPSEC_BLOCKING

Conversation

@cbeauchesne

@cbeauchesne cbeauchesne commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Per title
  • Also harden the compress step, for future use case like that : if there is nothing to compress, exit without any complain

Motivation

It has been merged into APPSEC_BLOCKING_FULL_DENYLIST DataDog/system-tests#5277

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@cbeauchesne
cbeauchesne requested a review from a team as a code owner September 24, 2025 08:00
@cbeauchesne cbeauchesne changed the title Removes APPSEC_BLOCKING from system-tests chore(ci): removes APPSEC_BLOCKING from system-tests Sep 24, 2025
@pr-commenter

pr-commenter Bot commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-24 13:55:49

Comparing candidate commit 2cfed2c in PR branch cbeauchesne/APPSEC_BLOCKING with baseline commit a7d75a7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio

darccio commented Sep 24, 2025

Copy link
Copy Markdown
Member

@cbeauchesne It seems that APPSEC_REQUEST_BLOCKING tests are complaining about the lack of files to compress: https://github.com/DataDog/dd-trace-go/actions/runs/17970396878/job/51111417395?pr=3988

@cbeauchesne
cbeauchesne force-pushed the cbeauchesne/APPSEC_BLOCKING branch from b3db557 to 6e37964 Compare September 24, 2025 09:21
@cbeauchesne

cbeauchesne commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

@darccio yes, few leftovers...

@jandro996 jandro996 mentioned this pull request Sep 24, 2025
Closed
7 tasks
@cbeauchesne

cbeauchesne commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-24 12:04:22 UTC ℹ️ Start processing command /merge

2025-09-24 12:04:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-09-24 12:17:15 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit e2ddb57:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@cbeauchesne

cbeauchesne commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-24 12:18:51 UTC ℹ️ Start processing command /merge

2025-09-24 12:19:01 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-24 14:01:08 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-09-24 14:21:20 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit a78c564:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@darccio darccio mentioned this pull request Sep 24, 2025
Closed
7 tasks
@eliottness
eliottness merged commit e2c8d45 into main Sep 24, 2025
258 of 259 checks passed
@eliottness
eliottness deleted the cbeauchesne/APPSEC_BLOCKING branch September 24, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

mergequeue-status: rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbeauchesne @darccio @eliottness @e-n-0