Skip to content

feat(contrib/haproxy): start empty haproxy contrib#3986

Merged
e-n-0 merged 1 commit into
mainfrom
flavien/contrib-start-empty-haproxy
Sep 24, 2025
Merged

feat(contrib/haproxy): start empty haproxy contrib#3986
e-n-0 merged 1 commit into
mainfrom
flavien/contrib-start-empty-haproxy

Conversation

@e-n-0

@e-n-0 e-n-0 commented Sep 22, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR initialize the haproxy contrib in the repo and will include a new AAP support for HAProxy using the Stream Offload Processing mechanism.

Motivation

New AAP proxy support.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 22, 2025
@e-n-0
e-n-0 marked this pull request as ready for review September 22, 2025 15:17
@e-n-0
e-n-0 requested review from a team as code owners September 22, 2025 15:17
@pr-commenter

pr-commenter Bot commented Sep 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-22 15:52:56

Comparing candidate commit a052aa9 in PR branch flavien/contrib-start-empty-haproxy with baseline commit b9b2eeb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@e-n-0
e-n-0 force-pushed the flavien/contrib-start-empty-haproxy branch 3 times, most recently from 33d2e55 to 769d3e8 Compare September 22, 2025 15:33
@e-n-0
e-n-0 force-pushed the flavien/contrib-start-empty-haproxy branch from 769d3e8 to a052aa9 Compare September 22, 2025 15:40
darccio
darccio approved these changes Sep 24, 2025
View reviewed changes

@darccio darccio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-n-0

e-n-0 commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-24 09:23:14 UTC ℹ️ Start processing command /merge

2025-09-24 09:23:19 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 17m (p90).

2025-09-24 09:35:47 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

@e-n-0

e-n-0 commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

/merge -c

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-24 09:35:35 UTC ℹ️ Start processing command /merge -c

@e-n-0
e-n-0 merged commit a7d75a7 into main Sep 24, 2025
263 of 264 checks passed
@e-n-0
e-n-0 deleted the flavien/contrib-start-empty-haproxy branch September 24, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e-n-0 @darccio @eliottness