Skip to content

fix(proxy): multiple analysis of truncated body#3981

Merged
e-n-0 merged 2 commits into
mainfrom
flavien/asm/proxy/fix-body-waf
Sep 22, 2025
Merged

fix(proxy): multiple analysis of truncated body#3981
e-n-0 merged 2 commits into
mainfrom
flavien/asm/proxy/fix-body-waf

Conversation

@e-n-0

@e-n-0 e-n-0 commented Sep 19, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR fixes a bug where a truncated body would be analyzed multiple times if more request body messages where sent after the truncation.

Motivation

Bug fix

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter

pr-commenter Bot commented Sep 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-22 08:45:31

Comparing candidate commit c44c4d5 in PR branch flavien/asm/proxy/fix-body-waf with baseline commit 847743a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@e-n-0
e-n-0 force-pushed the flavien/asm/proxy/fix-body-waf branch from f916c9b to d6c1a59 Compare September 19, 2025 11:45
@e-n-0
e-n-0 marked this pull request as ready for review September 19, 2025 14:53
@e-n-0
e-n-0 requested a review from a team as a code owner September 19, 2025 14:53
@e-n-0
e-n-0 requested a review from eliottness September 19, 2025 14:53
@eliottness Graphite App

eliottness commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 19, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-19 16:23:43 UTC ℹ️ Start processing command /merge

2025-09-19 16:23:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 16m (p90).

2025-09-19 16:35:34 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 40d7d3b:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@eliottness Graphite App

eliottness commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 22, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-22 08:08:36 UTC ℹ️ Start processing command /merge

2025-09-22 08:08:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 17m (p90).

2025-09-22 08:22:36 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit ca85414:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@e-n-0

e-n-0 commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 22, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-22 08:32:40 UTC ℹ️ Start processing command /merge

2025-09-22 08:32:45 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 17m (p90).

2025-09-22 08:32:55 UTC ❌ MergeQueue: This merge request was updated

This PR is rejected because it was updated

@e-n-0

e-n-0 commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 22, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-22 11:58:08 UTC ℹ️ Start processing command /merge

2025-09-22 11:58:12 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 17m (p90).

2025-09-22 12:19:21 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit c68aaf0:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@e-n-0
e-n-0 merged commit b9b2eeb into main Sep 22, 2025
355 of 364 checks passed
@e-n-0
e-n-0 deleted the flavien/asm/proxy/fix-body-waf branch September 22, 2025 12:19
e-n-0 added a commit that referenced this pull request Sep 24, 2025
@e-n-0 @eliottness
fix(proxy): multiple analysis of truncated body (#3981)
eaaa3e8 
Co-authored-by: Eliott Bouhana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

mergequeue-status: rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e-n-0 @eliottness