Skip to content

chore(go.mod): upgrade go-libddwaf#3980

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/instrumentation-appsec
Sep 19, 2025
Merged

chore(go.mod): upgrade go-libddwaf#3980
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/instrumentation-appsec

Conversation

@eliottness

@eliottness eliottness commented Sep 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Add instrumentation/appsec to the @DataDog/asm-go ownership

Motivation

This was probably removed inadvertently at some point

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
eliottness requested a review from a team as a code owner September 19, 2025 08:57
@eliottness

eliottness commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 19, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-19 09:00:16 UTC ℹ️ Start processing command /merge

2025-09-19 09:00:26 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-19 09:17:16 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 16m (p90).

2025-09-19 09:30:07 UTC ℹ️ MergeQueue: This merge request was merged

@pr-commenter

pr-commenter Bot commented Sep 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-19 09:12:22

Comparing candidate commit 557a2c3 in PR branch eliottness/instrumentation-appsec with baseline commit 3119b73 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@dd-mergequeue
dd-mergequeue Bot merged commit 25d82fd into main Sep 19, 2025
245 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/instrumentation-appsec branch September 19, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes
@e-n-0 e-n-0 e-n-0 approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliottness @RomainMuller @e-n-0