Skip to content

chore: switch yaml dependency#3976

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
ben.db/VULN-12552-change-go-yaml
Sep 18, 2025
Merged

chore: switch yaml dependency#3976
dd-mergequeue[bot] merged 1 commit into
mainfrom
ben.db/VULN-12552-change-go-yaml

Conversation

@genesor

@genesor genesor commented Sep 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Switch from unsupported gopkg.in/yaml.v3 to yaml/go-yaml

Motivation

Current package is unsupported. We had a request to move away from this package.

Note: this is still an indirect dependency as it's used by our dependencies.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@genesor
genesor requested a review from a team as a code owner September 17, 2025 20:25
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 17, 2025
@pr-commenter

pr-commenter Bot commented Sep 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-18 09:49:56

Comparing candidate commit 7e6f357 in PR branch ben.db/VULN-12552-change-go-yaml with baseline commit df15cd8 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio

darccio commented Sep 18, 2025

Copy link
Copy Markdown
Member

@genesor Shouldn't there be some import URL changes or replace directives? How is this dependency being used?

@kakkoyun

kakkoyun commented Sep 18, 2025

Copy link
Copy Markdown
Member

We should consider using https://github.com/yaml/go-yaml It's a maintained fork of the original package. Kubernetes and Prometheus decided to migrate to that one instead of goccy/go-yaml because they plan to change the API and behavior in subtle ways prometheus/proposals#49 (comment)

@genesor

genesor commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

@genesor Shouldn't there be some import URL changes or replace directives? How is this dependency being used?

@darccio there is only one use in stableconfig here and it has been updated.

You have to spot it in the middle of all the go.mod 😄

@genesor
genesor force-pushed the ben.db/VULN-12552-change-go-yaml branch from ab903f4 to 7e6f357 Compare September 18, 2025 09:35
@darccio

darccio commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

You have to spot it in the middle of all the go.mod 😄

go.mod soup :bufo-dizzy:

I think we need to start to do stacked PRs when we face this kind of situation.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 18, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

TestUnshallowGitRepository from github.com/DataDog/dd-trace-go/v2/internal/civisibility/utils (Datadog) (✨ Fix with BitsAI) 
Failed

=== RUN   TestUnshallowGitRepository
    git_test.go:80: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/internal/civisibility/utils/git_test.go:80
        	Error:      	Received unexpected error:
        	            	civisibility.unshallow: error: exit status 128
        	            	fatal: shallow file has changed since we read it
        	Test:       	TestUnshallowGitRepository
--- FAIL: TestUnshallowGitRepository (2.09s)

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7e6f357 | Docs | Was this helpful? Give us feedback!

@genesor

genesor commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-18 11:51:40 UTC ℹ️ Start processing command /merge

2025-09-18 11:51:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 16m (p90).

2025-09-18 12:10:48 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 33c136f:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@genesor

genesor commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-18 12:13:41 UTC ℹ️ Start processing command /merge

2025-09-18 12:13:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 16m (p90).

2025-09-18 12:25:40 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit e1f4103 into main Sep 18, 2025
293 of 297 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the ben.db/VULN-12552-change-go-yaml branch September 18, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@genesor @darccio @kakkoyun @eliottness