Skip to content

fix(.github/workflows): fix smoke-tests to avoid breaking changes in v0.70.x#3973

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
dario.castane/quick-fix-incident-43109
Sep 16, 2025
Merged

fix(.github/workflows): fix smoke-tests to avoid breaking changes in v0.70.x#3973
dd-mergequeue[bot] merged 3 commits into
mainfrom
dario.castane/quick-fix-incident-43109

Conversation

@darccio

@darccio darccio commented Sep 16, 2025

Copy link
Copy Markdown
Member

What does this PR do?

fix go get -u failure first seen here

Motivation

https://app.datadoghq.com/incidents/43109 & #3972

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner September 16, 2025 14:23
@pr-commenter

pr-commenter Bot commented Sep 16, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-16 16:01:46

Comparing candidate commit bee2c44 in PR branch dario.castane/quick-fix-incident-43109 with baseline commit ca6a4cf in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@jackgopack4

Copy link
Copy Markdown

would we need to add some commands to "go get" these packages in the PACKAGES" directories? (i.e. ./internal/... ./ddtrace/... ./profiler/... ./appsec/... ./instrumentation/...`)

@darccio

darccio commented Sep 16, 2025

Copy link
Copy Markdown
Member Author

would we need to add some commands to "go get" these packages in the PACKAGES" directories? (i.e. ./internal/... ./ddtrace/... ./profiler/... ./appsec/... ./instrumentation/...`)

We don't need to, as these packages are part of the root module. The other nested modules are updated when running this command:

for d in `find . -iname go.mod | xargs -n1 dirname`; do pushd $d; go mod tidy; popd; done;

@darccio

darccio commented Sep 16, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 16, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-16 16:26:56 UTC ℹ️ Start processing command /merge


2025-09-16 16:27:10 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-09-16 16:43:37 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 15m (p90).


2025-09-16 16:58:45 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit ce9b743 into main Sep 16, 2025
359 of 364 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the dario.castane/quick-fix-incident-43109 branch September 16, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants