Skip to content

fix: Orchestrion initializes Gorm plugin twice#3968

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
hannahkm/fix-orchestrion-gorm
Sep 15, 2025
Merged

fix: Orchestrion initializes Gorm plugin twice#3968
dd-mergequeue[bot] merged 2 commits into
mainfrom
hannahkm/fix-orchestrion-gorm

Conversation

@hannahkm

@hannahkm hannahkm commented Sep 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Does not re-initialize our tracer plugin if we are already using it.

Motivation

In certain scenarios, we are initializing twice, which is causing errors and preventing customers from using Gorm with Orchestrion.

APMS-17130

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@hannahkm
hannahkm requested a review from a team as a code owner September 15, 2025 14:17
kakkoyun
kakkoyun approved these changes Sep 15, 2025
View reviewed changes

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 15, 2025
@hannahkm

hannahkm commented Sep 15, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 15, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-15 14:21:01 UTC ℹ️ Start processing command /merge

2025-09-15 14:21:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-15 15:07:36 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 15m (p90).

2025-09-15 15:26:07 UTC ℹ️ MergeQueue: This merge request was merged

@pr-commenter

pr-commenter Bot commented Sep 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-15 14:51:27

Comparing candidate commit 3b8f7bd in PR branch hannahkm/fix-orchestrion-gorm with baseline commit 6672251 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@dd-mergequeue
dd-mergequeue Bot merged commit 939e012 into main Sep 15, 2025
243 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the hannahkm/fix-orchestrion-gorm branch September 15, 2025 15:25
hannahkm added a commit that referenced this pull request Sep 15, 2025
@hannahkm
fix: Orchestrion initializes Gorm plugin twice (#3968)
046fcdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@genesor genesor genesor approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hannahkm @kakkoyun @genesor